Skip to content

ref(build): Add central build directory to packages without CDN bundles (Part 2) #4868

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 10 commits into from
Apr 6, 2022

Conversation

Lms24
Copy link
Member

@Lms24 Lms24 commented Apr 6, 2022

Background

This PR marks the final step of adding the central build directory to every package in our monorepo. It adds this directory to the remaining packages without CDN bundles. The first packages were converted in #4854.

Changes

This PR adds the central build directory to the following packages:

  • NextJS
  • Node
  • React
  • Serverless
  • Types
  • Utils
  • Vue

A detailed overview of the changes is given in #4854.

For Serverless, the build-awslambda-layer.js file was adjusted as well to work with the build dir changes. Note that the structure inside the resulting Zip file is changed as well (it now contains the unmodified package.json and the build directory). TBD: Is this fine or do we need to adjust this one as well?

ref: https://getsentry.atlassian.net/browse/WEB-675

@Lms24 Lms24 requested review from lobsterkatie and AbhiPrasad April 6, 2022 12:00
@Lms24 Lms24 changed the title ref(build): Add central build directory to packages without CDN bundles (Part 2) ref(build): Add central build directory to packages without CDN bundles (Part 2) Apr 6, 2022
@Lms24 Lms24 added this to the Pre 7.0.0 Work milestone Apr 6, 2022
@Lms24 Lms24 force-pushed the lms-build-dir-packages-no-bundles-ii branch from 255e247 to cbf2a4d Compare April 6, 2022 12:21
@github-actions
Copy link
Contributor

github-actions bot commented Apr 6, 2022

size-limit report 📦

Path Size
@sentry/browser - ES5 CDN Bundle (gzipped + minified) 20.24 KB (-0.01% 🔽)
@sentry/browser - ES5 CDN Bundle (minified) 65.17 KB (0%)
@sentry/browser - ES6 CDN Bundle (gzipped + minified) 18.89 KB (-0.01% 🔽)
@sentry/browser - ES6 CDN Bundle (minified) 58.15 KB (0%)
@sentry/browser - Webpack (gzipped + minified) 23.25 KB (0%)
@sentry/browser - Webpack (minified) 82.13 KB (0%)
@sentry/react - Webpack (gzipped + minified) 23.29 KB (0%)
@sentry/nextjs Client - Webpack (gzipped + minified) 47.84 KB (-0.47% 🔽)
@sentry/browser + @sentry/tracing - ES5 CDN Bundle (gzipped + minified) 26.17 KB (-0.01% 🔽)
@sentry/browser + @sentry/tracing - ES6 CDN Bundle (gzipped + minified) 24.52 KB (-0.01% 🔽)

@Lms24 Lms24 force-pushed the lms-build-dir-packages-no-bundles-ii branch from f0a8e66 to 6f3b97a Compare April 6, 2022 15:18
@Lms24 Lms24 force-pushed the lms-build-dir-packages-no-bundles-ii branch from 6f3b97a to 8fef52c Compare April 6, 2022 15:58
Copy link
Member

@AbhiPrasad AbhiPrasad left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🚀

@AbhiPrasad AbhiPrasad enabled auto-merge (squash) April 6, 2022 16:00
Copy link
Member

@lobsterkatie lobsterkatie left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good! Two questions below, but otherwise I think this is good to go!

@lobsterkatie lobsterkatie disabled auto-merge April 6, 2022 16:08
@lobsterkatie lobsterkatie enabled auto-merge (squash) April 6, 2022 18:29
@lobsterkatie lobsterkatie merged commit 57f4832 into master Apr 6, 2022
@lobsterkatie lobsterkatie deleted the lms-build-dir-packages-no-bundles-ii branch April 6, 2022 18:45
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants