-
-
Notifications
You must be signed in to change notification settings - Fork 1.7k
ref(build): Add central build
directory to packages without CDN bundles (Part 2)
#4868
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
build
directory to packages without CDN bundles (Part 2)
255e247
to
cbf2a4d
Compare
size-limit report 📦
|
f0a8e66
to
6f3b97a
Compare
6f3b97a
to
8fef52c
Compare
AbhiPrasad
approved these changes
Apr 6, 2022
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
🚀
lobsterkatie
reviewed
Apr 6, 2022
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good! Two questions below, but otherwise I think this is good to go!
Merged
3 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Background
This PR marks the final step of adding the central
build
directory to every package in our monorepo. It adds this directory to the remaining packages without CDN bundles. The first packages were converted in #4854.Changes
This PR adds the central
build
directory to the following packages:A detailed overview of the changes is given in #4854.
For Serverless, the
build-awslambda-layer.js
file was adjusted as well to work with the build dir changes. Note that the structure inside the resulting Zip file is changed as well (it now contains the unmodifiedpackage.json
and thebuild
directory). TBD: Is this fine or do we need to adjust this one as well?ref: https://getsentry.atlassian.net/browse/WEB-675