-
-
Notifications
You must be signed in to change notification settings - Fork 1.7k
doc(migration): Add Backend
removal and Transport
injection to migration docs
#4934
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
lforst
approved these changes
Apr 13, 2022
lforst
approved these changes
Apr 13, 2022
size-limit report 📦
|
move it to "General API Changes" for the time being until we finalize the user-facing changes add TODOs for Transport injection, once more changes are coming in
56408db
to
08479ce
Compare
Lms24
added a commit
that referenced
this pull request
Apr 26, 2022
…gration docs (#4934) Add two small bullet points to the "General API changes" section, briefly explaining the removal of `Backend` and the injection of `Transport`s. The transport injection part needs to be revisited once we switch over to just using `NewTransport` as well as when we're passing the transports as `options` properties to the client constructors.
lobsterkatie
pushed a commit
that referenced
this pull request
Apr 26, 2022
…ion docs (#4934) Add two small bullet points to the "General API changes" section, briefly explaining the removal of `Backend` and the injection of `Transport`s. The transport injection part needs to be revisited once we switch over to just using `NewTransport` as well as when we're passing the transports as `options` properties to the client constructors.
lobsterkatie
pushed a commit
that referenced
this pull request
Apr 26, 2022
…ion docs (#4934) Add two small bullet points to the "General API changes" section, briefly explaining the removal of `Backend` and the injection of `Transport`s. The transport injection part needs to be revisited once we switch over to just using `NewTransport` as well as when we're passing the transports as `options` properties to the client constructors.
AbhiPrasad
pushed a commit
that referenced
this pull request
May 30, 2022
…ion docs (#4934) Add two small bullet points to the "General API changes" section, briefly explaining the removal of `Backend` and the injection of `Transport`s. The transport injection part needs to be revisited once we switch over to just using `NewTransport` as well as when we're passing the transports as `options` properties to the client constructors.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR adds two small bullet points to the "General API changes" section, briefly explaining the removal of
Backend
and the injection ofTransport
s. The transport injection part needs to be revisited once we switch over to just usingNewTransport
as well as when we're passing the transports asoptions
properties to the client constructors.ref: https://getsentry.atlassian.net/browse/WEB-834