Skip to content

fix(tests): Use non-delayed success endpoints to test erroneous cases. #4937

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Apr 14, 2022
Merged

fix(tests): Use non-delayed success endpoints to test erroneous cases. #4937

merged 1 commit into from
Apr 14, 2022

Conversation

onurtemizkan
Copy link
Collaborator

Fixes flaky integration tests for session-aggregation.

@github-actions
Copy link
Contributor

github-actions bot commented Apr 14, 2022 •
edited
Loading

size-limit report 📦

Path Size
@sentry/browser - ES5 CDN Bundle (gzipped + minified) 20.12 KB (-0.1% 🔽)
@sentry/browser - ES5 CDN Bundle (minified) 64.17 KB (-0.69% 🔽)
@sentry/browser - ES6 CDN Bundle (gzipped + minified) 18.76 KB (-0.53% 🔽)
@sentry/browser - ES6 CDN Bundle (minified) 57.72 KB (-0.43% 🔽)
@sentry/browser - Webpack (gzipped + minified) 23.36 KB (+0.52% 🔺)
@sentry/browser - Webpack (minified) 81.11 KB (-0.74% 🔽)
@sentry/react - Webpack (gzipped + minified) 23.39 KB (+0.5% 🔺)
@sentry/nextjs Client - Webpack (gzipped + minified) 47.85 KB (-0.44% 🔽)
@sentry/browser + @sentry/tracing - ES5 CDN Bundle (gzipped + minified) 25.99 KB (-0.31% 🔽)
@sentry/browser + @sentry/tracing - ES6 CDN Bundle (gzipped + minified) 24.33 KB (-0.62% 🔽)

@AbhiPrasad
Copy link
Member

@onurtemizkan what's the status on this? Can we merge in?

@onurtemizkan
Copy link
Collaborator Author

@AbhiPrasad, triggering CI one last time, then I think this should be ready to go. 🚀

@onurtemizkan onurtemizkan marked this pull request as ready for review April 14, 2022 14:45
@onurtemizkan onurtemizkan merged commit 961d3af into 7.x Apr 14, 2022
@onurtemizkan onurtemizkan deleted the onur/fix-flaky-session-test branch April 14, 2022 15:20
@AbhiPrasad AbhiPrasad added this to the 7.0.0 milestone Apr 25, 2022
Lms24 pushed a commit that referenced this pull request Apr 26, 2022
@onurtemizkan @Lms24
fix(tests): Use non-delayed success endpoints to test crashed and `…
84d3a42 
…errored` cases. (#4937)
lobsterkatie pushed a commit that referenced this pull request Apr 26, 2022
@onurtemizkan @lobsterkatie
fix(tests): Use non-delayed success endpoints to test crashed and `…
b62f515 
…errored` cases (#4937)
lobsterkatie pushed a commit that referenced this pull request Apr 26, 2022
@onurtemizkan @lobsterkatie
fix(tests): Use non-delayed success endpoints to test crashed and `…
9cf57fd 
…errored` cases (#4937)
AbhiPrasad pushed a commit that referenced this pull request May 30, 2022
@onurtemizkan @AbhiPrasad
fix(tests): Use non-delayed success endpoints to test crashed and `…
fe7c559 
…errored` cases (#4937)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@AbhiPrasad AbhiPrasad AbhiPrasad approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
7.0.0
Development

Successfully merging this pull request may close these issues.
2 participants
@onurtemizkan @AbhiPrasad