ref(utils): remove forget async utility function
#4941
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
this function just provides an unnecessary abstraction (and bundle size increase) around handling a Promise rejection.
size-limit report 📦
|
AbhiPrasad
approved these changes
Apr 14, 2022
Lms24
added a commit
that referenced
this pull request
Apr 26, 2022
remove the `forget()` function from Utils as it is a rather unnecessary abstraction around logging a rejected Promise via console.error and it bloats the bundle
lobsterkatie
pushed a commit
that referenced
this pull request
Apr 26, 2022
remove the `forget()` function from Utils as it is a rather unnecessary abstraction around logging a rejected Promise via console.error and it bloats the bundle
lobsterkatie
pushed a commit
that referenced
this pull request
Apr 26, 2022
remove the `forget()` function from Utils as it is a rather unnecessary abstraction around logging a rejected Promise via console.error and it bloats the bundle
AbhiPrasad
pushed a commit
that referenced
this pull request
May 30, 2022
remove the `forget()` function from Utils as it is a rather unnecessary abstraction around logging a rejected Promise via console.error and it bloats the bundle
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR removes the
forget()function from Utils as it is a rather unnecessary abstraction around logging a rejected Promise via console.error. It also adds to bundle size. The PR removes all (=2) calls to it and instead callslogger.errorin the respective places.ref: https://getsentry.atlassian.net/browse/WEB-826