Skip to content

fix(build): Cache gatsby plugin types files in CI #4944

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Apr 14, 2022

Conversation

lobsterkatie
Copy link
Member

This is a follow up to #4928, which added the creation of types files for the code in the gatsby SDK which lives outside of src/. One change which was missed was to have GHA include these new files in the build cache, so that they are available when tests are run. This fixes that oversight.

@github-actions
Copy link
Contributor

size-limit report 📦

Path Size
@sentry/browser - ES5 CDN Bundle (gzipped + minified) 20.19 KB (+0.28% 🔺)
@sentry/browser - ES5 CDN Bundle (minified) 64.33 KB (-0.44% 🔽)
@sentry/browser - ES6 CDN Bundle (gzipped + minified) 18.84 KB (-0.1% 🔽)
@sentry/browser - ES6 CDN Bundle (minified) 57.94 KB (-0.06% 🔽)
@sentry/browser - Webpack (gzipped + minified) 23.41 KB (+0.76% 🔺)
@sentry/browser - Webpack (minified) 81.21 KB (-0.63% 🔽)
@sentry/react - Webpack (gzipped + minified) 23.46 KB (+0.79% 🔺)
@sentry/nextjs Client - Webpack (gzipped + minified) 47.96 KB (-0.19% 🔽)
@sentry/browser + @sentry/tracing - ES5 CDN Bundle (gzipped + minified) 26.04 KB (-0.12% 🔽)
@sentry/browser + @sentry/tracing - ES6 CDN Bundle (gzipped + minified) 24.42 KB (-0.27% 🔽)

@lobsterkatie lobsterkatie merged commit 949e90e into 7.x Apr 14, 2022
@lobsterkatie lobsterkatie deleted the kmclb-cache-gatsby-plugin-types-in-ci branch April 14, 2022 18:52
@AbhiPrasad AbhiPrasad added this to the 7.0.0 milestone Apr 25, 2022
Lms24 pushed a commit that referenced this pull request Apr 26, 2022
This is a follow up to #4928, which added the creation of types files for the code in the gatsby SDK which lives outside of `src/`. One change which was missed was to have GHA include these new files in the build cache, so that they are available when tests are run. This fixes that oversight.
lobsterkatie added a commit that referenced this pull request Apr 26, 2022
This is a follow up to #4928, which added the creation of types files for the code in the gatsby SDK which lives outside of `src/`. One change which was missed was to have GHA include these new files in the build cache, so that they are available when tests are run. This fixes that oversight.
lobsterkatie added a commit that referenced this pull request Apr 26, 2022
This is a follow up to #4928, which added the creation of types files for the code in the gatsby SDK which lives outside of `src/`. One change which was missed was to have GHA include these new files in the build cache, so that they are available when tests are run. This fixes that oversight.
AbhiPrasad pushed a commit that referenced this pull request May 30, 2022
This is a follow up to #4928, which added the creation of types files for the code in the gatsby SDK which lives outside of `src/`. One change which was missed was to have GHA include these new files in the build cache, so that they are available when tests are run. This fixes that oversight.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants