Skip to content

fix(dev): Remove eslint cache when cleaning repo #4980

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Apr 27, 2022

Conversation

lobsterkatie
Copy link
Member

@lobsterkatie lobsterkatie commented Apr 26, 2022

This adds the eslint cache to the list of things which are removed when running the repo-level yarn clean command, to prevent false positives or negatives because of cached results.

@lobsterkatie lobsterkatie force-pushed the kmclb-remove-eslint-cache-when-cleaning branch from a1d4d9a to 76887c0 Compare April 26, 2022 08:51
@github-actions
Copy link
Contributor

github-actions bot commented Apr 26, 2022

size-limit report 📦

Path Size
@sentry/browser - ES5 CDN Bundle (gzipped + minified) 18.35 KB (-8.87% 🔽)
@sentry/browser - ES5 CDN Bundle (minified) 57.52 KB (-10.98% 🔽)
@sentry/browser - ES6 CDN Bundle (gzipped + minified) 17.13 KB (-9.18% 🔽)
@sentry/browser - ES6 CDN Bundle (minified) 51.75 KB (-10.73% 🔽)
@sentry/browser - Webpack (gzipped + minified) 20.94 KB (-9.88% 🔽)
@sentry/browser - Webpack (minified) 72.5 KB (-11.28% 🔽)
@sentry/react - Webpack (gzipped + minified) 20.98 KB (-9.89% 🔽)
@sentry/nextjs Client - Webpack (gzipped + minified) 45.97 KB (-4.34% 🔽)
@sentry/browser + @sentry/tracing - ES5 CDN Bundle (gzipped + minified) 24.13 KB (-7.45% 🔽)
@sentry/browser + @sentry/tracing - ES6 CDN Bundle (gzipped + minified) 22.64 KB (-7.51% 🔽)

@AbhiPrasad AbhiPrasad added this to the 7.0.0 milestone Apr 26, 2022
@lobsterkatie lobsterkatie force-pushed the kmclb-remove-eslint-cache-when-cleaning branch from 76887c0 to a188bdd Compare April 26, 2022 13:58
@lobsterkatie lobsterkatie force-pushed the kmclb-remove-eslint-cache-when-cleaning branch from a188bdd to 8bc1f42 Compare April 26, 2022 16:10
@lobsterkatie lobsterkatie force-pushed the 7.x branch 2 times, most recently from 0040b0f to 299aeb3 Compare April 26, 2022 22:40
@lobsterkatie lobsterkatie force-pushed the kmclb-remove-eslint-cache-when-cleaning branch 2 times, most recently from 431fbc7 to 0162aeb Compare April 27, 2022 07:39
@Lms24 Lms24 self-assigned this Apr 27, 2022
@lobsterkatie lobsterkatie force-pushed the kmclb-remove-eslint-cache-when-cleaning branch 2 times, most recently from 2fa58d6 to d4d62a3 Compare April 27, 2022 15:05
@lobsterkatie lobsterkatie force-pushed the kmclb-remove-eslint-cache-when-cleaning branch from d4d62a3 to b5f6d48 Compare April 27, 2022 15:58
@lobsterkatie lobsterkatie marked this pull request as ready for review April 27, 2022 18:12
@lobsterkatie lobsterkatie merged commit a71cfb9 into 7.x Apr 27, 2022
@lobsterkatie lobsterkatie deleted the kmclb-remove-eslint-cache-when-cleaning branch April 27, 2022 18:12
AbhiPrasad pushed a commit that referenced this pull request May 30, 2022
This adds the eslint cache to the list of things which are removed when running the repo-level `yarn clean` command, to prevent false positives or negatives because of cached results.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants