ref: Remove unneeded logic from transports #5002
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Previously we assumed it was necessary to return information from
transport.send()
to collect outcomes for client transports. The plan is to instead inject a hook/callback through the client, into the transports, that is responsible for collecting client reports within the transport itself. This makes the interface for the transports much less strict for anybody wanting to create their own transports, and it also allows us to delete a bunch of code that was used for managing the return values oftransport.send()
. Bundle size go ⬇️ Usability go ⬆️This PR removes the unneeded return values from transports and anything that is now unused.
Upcoming PRs for client transports will build on these changes so keep an eye out for that. :)
Ref: https://getsentry.atlassian.net/browse/WEB-775