Skip to content

fix(tracing): Fix missing page load metrics in Electron renderer #5187

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Jun 2, 2022
Merged

fix(tracing): Fix missing page load metrics in Electron renderer #5187

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
aca7955
Fix missing metrics in Electron
timfish May 31, 2022
5585aa9
Improve detection to check used apis
timfish May 31, 2022
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 3 additions & 3 deletions packages/tracing/src/browser/metrics/index.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,6 +1,6 @@
/* eslint-disable max-lines */
import { Measurements } from '@sentry/types';
import { browserPerformanceTimeOrigin, getGlobalObject, htmlTreeAsString, isNodeEnv, logger } from '@sentry/utils';
import { browserPerformanceTimeOrigin, getGlobalObject, htmlTreeAsString, logger } from '@sentry/utils';

import { IS_DEBUG_BUILD } from '../../flags';
import { Transaction } from '../../transaction';
Expand All @@ -14,8 +14,8 @@ import { _startChild, isMeasurementValue } from './utils';

const global = getGlobalObject<Window>();

function getBrowserPerformanceAPI(): false | Performance {
return !isNodeEnv() && global && global.document && global.performance;
function getBrowserPerformanceAPI(): Performance | undefined {
return global && global.addEventListener && global.performance;
}

let _performanceCursor: number = 0;
Expand Down