ref(tests): Add TestEnv class to Node integration tests.
#5633
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
size-limit report 📦
|
|
We'll need to rebase this on top of #5512 - otherwise looks great to me! |
onurtemizkan
force-pushed
the
onur/node-int-tests-testenv-class
branch
from
5b36b58 to
f9a6e0b
Compare
|
@AbhiPrasad - rebased the PR 👍 |
AbhiPrasad
approved these changes
Aug 30, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Following up: #5579 and #5596
Ref: #5579 (review)
Refactored Node integration test helpers, to use a
TestEnvinstance for each test. This will help avoid explicitly passingserverandurlback and forth.Remix server-side tests also extend the
TestEnvclass to implement Remix-specific initialization logic.