Skip to content

ref(nextjs): Consolidate to use single setName call #5683

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Sep 1, 2022

Conversation

AbhiPrasad
Copy link
Member

@AbhiPrasad AbhiPrasad commented Sep 1, 2022

helps us get prepped for #5679, related to #5681 and #5682

Please merge this in without me if I'm not available!

Remove usage `setMetadata` in favour of adding the source to `setName`
@AbhiPrasad AbhiPrasad requested review from a team, lforst and Lms24 and removed request for a team September 1, 2022 18:43
@AbhiPrasad AbhiPrasad mentioned this pull request Sep 1, 2022
10 tasks
@github-actions
Copy link
Contributor

github-actions bot commented Sep 1, 2022

size-limit report 📦

Path Size
@sentry/browser - ES5 CDN Bundle (gzipped + minified) 19.42 KB (+0.02% 🔺)
@sentry/browser - ES5 CDN Bundle (minified) 60.08 KB (0%)
@sentry/browser - ES6 CDN Bundle (gzipped + minified) 17.99 KB (+0.02% 🔺)
@sentry/browser - ES6 CDN Bundle (minified) 52.94 KB (0%)
@sentry/browser - Webpack (gzipped + minified) 19.79 KB (0%)
@sentry/browser - Webpack (minified) 64.33 KB (0%)
@sentry/react - Webpack (gzipped + minified) 19.81 KB (0%)
@sentry/nextjs Client - Webpack (gzipped + minified) 44.66 KB (0%)
@sentry/browser + @sentry/tracing - ES5 CDN Bundle (gzipped + minified) 25.91 KB (+0.01% 🔺)
@sentry/browser + @sentry/tracing - ES6 CDN Bundle (gzipped + minified) 24.28 KB (+0.01% 🔺)

@AbhiPrasad AbhiPrasad merged commit 64122e8 into master Sep 1, 2022
@AbhiPrasad AbhiPrasad deleted the abhi-ref-nextjs-name-set branch September 1, 2022 19:13
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants