Skip to content

test(e2e): Validate test app setup #5849

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Sep 28, 2022
Merged

Conversation

lforst
Copy link
Contributor

@lforst lforst commented Sep 28, 2022

Ref: #5506

Adds a validation script to the E2E test package that does a plausibility check if E2E test apps have a correct setup (i.e. they use the test registry and ignore lockfiles).

@lforst lforst force-pushed the lforst-validate-test-app-setup branch from 5429b36 to a551e42 Compare September 28, 2022 16:55
@lforst lforst marked this pull request as ready for review September 28, 2022 16:55
@lforst lforst requested a review from AbhiPrasad September 28, 2022 16:56
Copy link
Member

@AbhiPrasad AbhiPrasad left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Solid enough for now

@github-actions
Copy link
Contributor

github-actions bot commented Sep 28, 2022

size-limit report 📦

Path Size
@sentry/browser - ES5 CDN Bundle (gzipped + minified) 19.47 KB (+0.02% 🔺)
@sentry/browser - ES5 CDN Bundle (minified) 60.23 KB (0%)
@sentry/browser - ES6 CDN Bundle (gzipped + minified) 18.09 KB (-0.01% 🔽)
@sentry/browser - ES6 CDN Bundle (minified) 53.16 KB (0%)
@sentry/browser - Webpack (gzipped + minified) 19.85 KB (0%)
@sentry/browser - Webpack (minified) 64.49 KB (0%)
@sentry/react - Webpack (gzipped + minified) 19.87 KB (0%)
@sentry/nextjs Client - Webpack (gzipped + minified) 44.78 KB (0%)
@sentry/browser + @sentry/tracing - ES5 CDN Bundle (gzipped + minified) 25.92 KB (+0.01% 🔺)
@sentry/browser + @sentry/tracing - ES6 CDN Bundle (gzipped + minified) 24.36 KB (+0.01% 🔺)

@lforst lforst merged commit 4c6c6f6 into master Sep 28, 2022
@lforst lforst deleted the lforst-validate-test-app-setup branch September 28, 2022 17:25
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants