Skip to content

fix(build): Revert unintended Replay tsconfig changes #6300

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 3 commits into from
Nov 25, 2022

Conversation

Lms24
Copy link
Member

@Lms24 Lms24 commented Nov 25, 2022

This PR reverts a few changes I unintentionally comitted and merged in #6288. It caused build errors which for some reasons did not our CI's "build" step to fail but caused size-check fails in https://github.com/getsentry/sentry-javascript/actions/runs/3546454900

@github-actions
Copy link
Contributor

github-actions bot commented Nov 25, 2022

size-limit report 📦

Path Size
@sentry/browser - ES5 CDN Bundle (gzipped + minified) 19.54 KB (+0.19% 🔺)
@sentry/browser - ES5 CDN Bundle (minified) 60.42 KB (+0.23% 🔺)
@sentry/browser - ES6 CDN Bundle (gzipped + minified) 18.21 KB (+0.25% 🔺)
@sentry/browser - ES6 CDN Bundle (minified) 53.77 KB (+0.26% 🔺)
@sentry/browser - Webpack (gzipped + minified) 19.94 KB (+0.2% 🔺)
@sentry/browser - Webpack (minified) 65.25 KB (+0.21% 🔺)
@sentry/react - Webpack (gzipped + minified) 19.96 KB (+0.19% 🔺)
@sentry/nextjs Client - Webpack (gzipped + minified) 45.96 KB (+0.08% 🔺)
@sentry/browser + @sentry/tracing - ES5 CDN Bundle (gzipped + minified) 26.41 KB (+0.18% 🔺)
@sentry/browser + @sentry/tracing - ES6 CDN Bundle (gzipped + minified) 24.83 KB (+0.21% 🔺)
@sentry/replay index.js 83.67 KB (+0.02% 🔺)
@sentry/replay - Webpack (gzipped + minified) 83.69 KB (+0.02% 🔺)
@sentry/replay - Webpack (minified) 272.17 KB (+0.03% 🔺)

@Lms24 Lms24 changed the title ref(build): revert unintended tsconfig changes ref(build): Revert unintended Replay tsconfig changes Nov 25, 2022
@Lms24 Lms24 changed the title ref(build): Revert unintended Replay tsconfig changes fix(build): Revert unintended Replay tsconfig changes Nov 25, 2022
@Lms24 Lms24 requested a review from mydea November 25, 2022 09:50
@Lms24 Lms24 marked this pull request as ready for review November 25, 2022 09:50
@Lms24 Lms24 enabled auto-merge (squash) November 25, 2022 10:12
@Lms24 Lms24 merged commit d825549 into master Nov 25, 2022
@Lms24 Lms24 deleted the lms-replay-revert-tsconfig branch November 25, 2022 10:15
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants