Skip to content

fix(otel): Set root transaction name to be route #6334

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Nov 29, 2022

Conversation

AbhiPrasad
Copy link
Member

fixes #6301

If a low cardinality http.route is not defined, we fall back to http.target and set transaction source to be url. In that case, we should special case http.target === / since we know the / root transaction has no parameters. Therefore we categorize it as transaction source route.

@AbhiPrasad AbhiPrasad added this to the OpenTelemetry Support milestone Nov 29, 2022
@AbhiPrasad AbhiPrasad requested a review from mydea November 29, 2022 14:55
@AbhiPrasad AbhiPrasad self-assigned this Nov 29, 2022
@github-actions
Copy link
Contributor

size-limit report 📦

Path Size
@sentry/browser - ES5 CDN Bundle (gzipped + minified) 19.54 KB (-0.01% 🔽)
@sentry/browser - ES5 CDN Bundle (minified) 60.42 KB (0%)
@sentry/browser - ES6 CDN Bundle (gzipped + minified) 18.21 KB (+0.03% 🔺)
@sentry/browser - ES6 CDN Bundle (minified) 53.76 KB (0%)
@sentry/browser - Webpack (gzipped + minified) 19.94 KB (0%)
@sentry/browser - Webpack (minified) 65.25 KB (0%)
@sentry/react - Webpack (gzipped + minified) 19.96 KB (0%)
@sentry/nextjs Client - Webpack (gzipped + minified) 45.96 KB (0%)
@sentry/browser + @sentry/tracing - ES5 CDN Bundle (gzipped + minified) 26.41 KB (-0.01% 🔽)
@sentry/browser + @sentry/tracing - ES6 CDN Bundle (gzipped + minified) 24.83 KB (+0.01% 🔺)
@sentry/replay index.js 63.38 KB (0%)
@sentry/replay - Webpack (gzipped + minified) 63.39 KB (0%)
@sentry/replay - Webpack (minified) 204.81 KB (0%)

@AbhiPrasad AbhiPrasad enabled auto-merge (squash) November 29, 2022 15:10
@AbhiPrasad AbhiPrasad merged commit 2972c53 into master Nov 29, 2022
@AbhiPrasad AbhiPrasad deleted the abhi-otel-root-heuristic branch November 29, 2022 15:17
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[Express-OTEL] Transaction Name Quality
2 participants