fix(replay): Add missing rrweb type declarations #6464
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR fixes a TypeScript error we encountered when using the 7.24.1 NPM package:
To generate type declarations, we use
tsc
(yarn build:types
) which doesn't pull external type declarations into the resulting.d.ts
files. We import types from rrweb which our internal types rely on. Because we now vendor rrweb, the rrweb-internal types are no longer getting installed in our users node_modules, producing typescript errors when they build their projects. To fix this, this PR vendors a "light" version of the two rrweb types we use.