Skip to content

feat(core): Add scope.getLastBreadcrumb() #6495

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Dec 12, 2022
Merged

feat(core): Add scope.getLastBreadcrumb() #6495

merged 1 commit into from
Dec 12, 2022

Conversation

mydea
Copy link
Member

@mydea mydea commented Dec 12, 2022

This is needed by replay, which can then stop using the private API _breadcrumbs.

@mydea
feat(core): Add scope.getLastBreadcrumb()
0724223 
This is needed by replay, which can then stop using the private API `_breadcrumbs`.
@mydea mydea added the Package: core Issues related to the Sentry Core SDK label Dec 12, 2022
@mydea mydea requested review from billyvg and Lms24 December 12, 2022 09:01
@mydea mydea self-assigned this Dec 12, 2022
This was referenced Dec 12, 2022
Closed
Merged
@github-actions
Copy link
Contributor

size-limit report 📦

Path Size
@sentry/browser - ES5 CDN Bundle (gzipped + minified) 19.7 KB (+0.05% 🔺)
@sentry/browser - ES5 CDN Bundle (minified) 61.03 KB (+0.12% 🔺)
@sentry/browser - ES6 CDN Bundle (gzipped + minified) 18.49 KB (+0.09% 🔺)
@sentry/browser - ES6 CDN Bundle (minified) 54.56 KB (+0.1% 🔺)
@sentry/browser - Webpack (gzipped + minified) 20.28 KB (+0.06% 🔺)
@sentry/browser - Webpack (minified) 66.33 KB (+0.11% 🔺)
@sentry/react - Webpack (gzipped + minified) 20.3 KB (+0.06% 🔺)
@sentry/nextjs Client - Webpack (gzipped + minified) 47.3 KB (+0.03% 🔺)
@sentry/browser + @sentry/tracing - ES5 CDN Bundle (gzipped + minified) 26.68 KB (+0.05% 🔺)
@sentry/browser + @sentry/tracing - ES6 CDN Bundle (gzipped + minified) 25.13 KB (+0.08% 🔺)
@sentry/replay ES6 CDN Bundle (gzipped + minified) 41.84 KB (+0.02% 🔺)
@sentry/replay - Webpack (gzipped + minified) 37.89 KB (0%)

Lms24
Lms24 approved these changes Dec 12, 2022
View reviewed changes
Copy link
Member

@Lms24 Lms24 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice one!

@mydea mydea merged commit 867c731 into master Dec 12, 2022
@mydea mydea deleted the fn/replay-avoid-_breadcrumbs branch December 12, 2022 09:39
@Lms24 Lms24 mentioned this pull request Dec 19, 2022
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Lms24 Lms24 Lms24 approved these changes

@billyvg billyvg Awaiting requested review from billyvg

Assignees

@mydea mydea

Labels
Package: core Issues related to the Sentry Core SDK
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@mydea @Lms24