Skip to content

chore(utils): Adjust JSDoc of rate limit functions #6748

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Jan 12, 2023

Conversation

Lms24
Copy link
Member

@Lms24 Lms24 commented Jan 12, 2023

While working on #6733, I noticed that the ratelimit.ts JSDocs could use a little rework as e.g. updateRateLimits's doc mentioned an incorrect return value.

@Lms24 Lms24 requested review from AbhiPrasad and mydea January 12, 2023 09:52
@Lms24 Lms24 force-pushed the lms-ratelimits-jsdoc branch from ddafcec to 1f1eefe Compare January 12, 2023 09:53
@Lms24 Lms24 changed the title chore(core): Adjust JSDoc of rate limit functions chore(utils): Adjust JSDoc of rate limit functions Jan 12, 2023
@github-actions
Copy link
Contributor

size-limit report 📦

Path Size
@sentry/browser - ES5 CDN Bundle (gzipped + minified) 19.84 KB (-0.01% 🔽)
@sentry/browser - ES5 CDN Bundle (minified) 61.46 KB (0%)
@sentry/browser - ES6 CDN Bundle (gzipped + minified) 18.62 KB (+0.02% 🔺)
@sentry/browser - ES6 CDN Bundle (minified) 55 KB (0%)
@sentry/browser - Webpack (gzipped + minified) 20.38 KB (0%)
@sentry/browser - Webpack (minified) 66.55 KB (0%)
@sentry/react - Webpack (gzipped + minified) 20.4 KB (0%)
@sentry/nextjs Client - Webpack (gzipped + minified) 47.63 KB (0%)
@sentry/browser + @sentry/tracing - ES5 CDN Bundle (gzipped + minified) 26.82 KB (+0.02% 🔺)
@sentry/browser + @sentry/tracing - ES6 CDN Bundle (gzipped + minified) 25.25 KB (-0.01% 🔽)
@sentry/replay ES6 CDN Bundle (gzipped + minified) 43.13 KB (0%)
@sentry/replay - Webpack (gzipped + minified) 38.33 KB (0%)

@Lms24 Lms24 enabled auto-merge (squash) January 12, 2023 10:03
@Lms24 Lms24 merged commit 7c8844f into master Jan 12, 2023
@Lms24 Lms24 deleted the lms-ratelimits-jsdoc branch January 12, 2023 10:10
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants