Skip to content

chore: make unit tests cacheable, fix package graph #7108

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
mydea merged 8 commits into from
Feb 20, 2023
Merged

chore: make unit tests cacheable, fix package graph #7108

Show file tree
Hide file tree
Changes from 1 commit
Commits
Show all changes
8 commits
Select commit Hold shift + click to select a range
806126b
chore: make unit tests cacheable, fix package graph
JamesHenry Feb 9, 2023
2f6a447
chore: revert broken alias change
JamesHenry Feb 9, 2023
bbe3c30
meta(changelog): Update CHANGELOG for 7.38.0
mydea Feb 17, 2023
b290fca
Merge pull request #7210 from getsentry/prepare-release/7.38.0
mydea Feb 17, 2023
dcab04e
Merge pull request #7218 from getsentry/develop
mydea Feb 17, 2023
e2db963
Merge remote-tracking branch 'origin/master' into cacheable-tests
JamesHenry Feb 17, 2023
1907418
chore: revert changelog
JamesHenry Feb 17, 2023
7098879
Apply suggestions from code review
mydea Feb 20, 2023
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
14 changes: 13 additions & 1 deletion nx.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -7,7 +7,9 @@
"build:bundle",
"build:transpile",
"build:types",
"lint:eslint"
"lint:eslint",
"test",
Copy link
Member

@mydea mydea Feb 17, 2023

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Let's maybe only start with caching test:unit, as the integration tests (for example) also make sure stuff keeps working with new versions of e.g. browsers, which is not really deterministic in this way.

WDYT @AbhiPrasad / @Lms24 / @lforst ?

Copy link
Member

@AbhiPrasad AbhiPrasad Feb 17, 2023

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

yes that makes sense to me

Copy link
Contributor Author

@JamesHenry JamesHenry Feb 17, 2023

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Reverted, I'll leave this one to you to revisit :)

"test:unit"
]
}
}
Expand Down Expand Up @@ -68,6 +70,16 @@
"lint:eslint": {
"inputs": ["default"],
"outputs": []
},
"test": {
"dependsOn": ["build:types", "^build:types", "build:transpile", "^build:transpile"],
"inputs": ["default"],
"outputs": ["{projectRoot}/coverage"]
},
"test:unit": {
"dependsOn": ["build:types", "^build:types", "build:transpile", "^build:transpile"],
"inputs": ["default"],
"outputs": ["{projectRoot}/coverage"]
}
}
}
4 changes: 2 additions & 2 deletions package.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -24,8 +24,8 @@
"lint": "lerna run lint",
"lint:eslint": "lerna run lint:eslint",
"postpublish": "lerna run --stream --concurrency 1 postpublish",
"test": "lerna run --ignore @sentry-internal/* test",
"test-ci-browser": "lerna run test --ignore \"@sentry/{node,opentelemetry-node,serverless,nextjs,remix,gatsby}\" --ignore @sentry-internal/*",
"test": "lerna run test --ignore @sentry-internal/*",
"test-ci-browser": "yarn test --ignore \"@sentry/{node,opentelemetry-node,serverless,nextjs,remix,gatsby}\"",
"test-ci-node": "ts-node ./scripts/node-unit-tests.ts"
},
"volta": {
Expand Down
1 change: 1 addition & 0 deletions packages/integrations/package.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -22,6 +22,7 @@
"tslib": "^1.9.3"
},
"devDependencies": {
"@sentry/browser": "7.36.0",
Copy link
Contributor Author

@JamesHenry JamesHenry Feb 9, 2023

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This relationship between these packages was missing and needed to be added to ensure task pipelines know what to do and in what order

"chai": "^4.1.2"
},
"scripts": {
Expand Down
1 change: 1 addition & 0 deletions packages/node/package.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -25,6 +25,7 @@
"tslib": "^1.9.3"
},
"devDependencies": {
"@sentry/tracing": "7.36.0",
Copy link
Contributor Author

@JamesHenry JamesHenry Feb 9, 2023

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This relationship between these packages was missing and needed to be added to ensure task pipelines know what to do and in what order

"@types/cookie": "0.3.2",
"@types/express": "^4.17.14",
"@types/lru-cache": "^5.1.0",
Expand Down