Skip to content

fix(browser): Support async in stack frame urls #7131

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 2 commits into from
Feb 10, 2023
Merged

fix(browser): Support async in stack frame urls #7131

merged 2 commits into from
Feb 10, 2023

Conversation

timfish
Copy link
Collaborator

@timfish timfish commented Feb 9, 2023 •
edited
Loading

Closes #7128

That regex is becoming a monster!

lforst
lforst approved these changes Feb 10, 2023
View reviewed changes
Copy link
Contributor

@lforst lforst left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice thank you!

@lforst
Copy link
Contributor

lforst commented Feb 10, 2023 •
edited
Loading

For its size, the regex is still strangely readable :D

@AbhiPrasad AbhiPrasad merged commit c3806eb into getsentry:develop Feb 10, 2023
@timfish timfish deleted the fix/async-frame-urls branch February 13, 2023 19:31
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@lforst lforst lforst approved these changes

@AbhiPrasad AbhiPrasad AbhiPrasad approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

[Stack Traces] Filename prepended with "async " causes issues
3 participants
@timfish @lforst @AbhiPrasad