feat(replay): Upgrade to [email protected]
#7133
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
size-limit report 📦
|
billyvg
commented
Feb 10, 2023
| it('maskAllText takes precedence over maskTextSelector when specifiying maskAllText:true', async () => { | ||
| const { replay } = await mockSdk({ replayOptions: { maskAllText: true, maskTextSelector: '[custom]' } }); | ||
|
|
||
| expect(replay['_recordingOptions'].maskTextSelector).toBe(MASK_ALL_TEXT_SELECTOR); |
There was a problem hiding this comment.
So this fixes another bug where maskTextSelector was wrong when maskAllText:true, this should have included the default mask selectors. (I guess this doesn't really matter since it's all masked anyway).
mydea
reviewed
Feb 10, 2023
Lms24
approved these changes
Feb 10, 2023
- feat: Add `maskAllText` option - feat: With maskAllText, mask the attributes: placeholder, title, `aria-label` - feat: fix masking on `textarea`
billyvg
force-pushed
the
feat-replay-update-rrweb-mask-all-text-and-placeholders
branch
from
428d191 to
0454d8f
Compare
billyvg
deleted the
feat-replay-update-rrweb-mask-all-text-and-placeholders
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
maskAllTextoptionaria-labeltextarea