Skip to content

feat(tracing|core): Remove transaction name change recording #7197

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Feb 16, 2023

Conversation

AbhiPrasad
Copy link
Member

The bundle size king strikes again.

In #5679 we added functionality to track transaction name changes. This was used to collect data about transaction name quality in the SDK.

In getsentry/relay#1671 we removed from relay the tracking of these name change metrics, so let's also remove them from the SDK.

@AbhiPrasad AbhiPrasad requested review from a team, mydea and Lms24 and removed request for a team February 15, 2023 16:33
@github-actions
Copy link
Contributor

github-actions bot commented Feb 15, 2023

size-limit report 📦

Path Size
@sentry/browser - ES5 CDN Bundle (gzipped + minified) 20.05 KB (-0.19% 🔽)
@sentry/browser - ES5 CDN Bundle (minified) 62.14 KB (-0.15% 🔽)
@sentry/browser - ES6 CDN Bundle (gzipped + minified) 18.68 KB (-0.19% 🔽)
@sentry/browser - ES6 CDN Bundle (minified) 55.28 KB (-0.15% 🔽)
@sentry/browser - Webpack (gzipped + minified) 20.41 KB (-0.17% 🔽)
@sentry/browser - Webpack (minified) 66.73 KB (-0.13% 🔽)
@sentry/react - Webpack (gzipped + minified) 20.44 KB (-0.17% 🔽)
@sentry/nextjs Client - Webpack (gzipped + minified) 47.78 KB (-0.25% 🔽)
@sentry/browser + @sentry/tracing - ES5 CDN Bundle (gzipped + minified) 26.93 KB (-0.39% 🔽)
@sentry/browser + @sentry/tracing - ES6 CDN Bundle (gzipped + minified) 25.2 KB (-0.38% 🔽)
@sentry/replay ES6 CDN Bundle (gzipped + minified) 42.52 KB (-0.01% 🔽)
@sentry/replay - Webpack (gzipped + minified) 36.72 KB (0%)
@sentry/browser + @sentry/tracing + @sentry/replay - ES6 CDN Bundle (gzipped + minified) 60.14 KB (-0.17% 🔽)
@sentry/browser + @sentry/replay - ES6 CDN Bundle (gzipped + minified) 53.74 KB (-0.06% 🔽)

@AbhiPrasad AbhiPrasad requested a review from lforst February 15, 2023 16:44
@mydea
Copy link
Member

mydea commented Feb 16, 2023

The bundle size king strikes again.

the-king-has-returned

@AbhiPrasad AbhiPrasad merged commit 5359ba9 into develop Feb 16, 2023
@AbhiPrasad AbhiPrasad deleted the abhi-remove-transaction-name-change branch February 16, 2023 11:06
@AbhiPrasad AbhiPrasad changed the title feat(tracing|core): Remove transaction name change propagation feat(tracing|core): Remove transaction name change recording Feb 16, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants