-
-
Notifications
You must be signed in to change notification settings - Fork 1.7k
feat(browser): Export BrowserTracing
from package
#7366
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Closed
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
lforst
approved these changes
Mar 7, 2023
mydea
approved these changes
Mar 7, 2023
This was referenced Mar 7, 2023
AbhiPrasad
commented
Mar 7, 2023
@@ -115,7 +115,8 @@ | |||
"typescript": "3.8.3" | |||
}, | |||
"resolutions": { | |||
"**/agent-base": "5" | |||
"**/agent-base": "5", | |||
"**/jest-resolve": "29.5.0" |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Have to bump this so that we get around jestjs/jest#9771, which requires Jest >= 28
One day I'll merge this and it will be glorious! |
size-limit report 📦
|
Closed
Closing this because it will break webpack 4 :( We can only make this change in v8. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
closes #7342
Building on the work in #7345, this PR exports
BrowserTracing
from the@sentry/browser
package.This means performance monitoring for the browser now looks like so:
If you don't want to use
BrowserTracing
, you'll have to add the tracing extensions yourself: