feat(core): Extend AsyncContextStrategy to allow reuse of existing context
#7778
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
AbhiPrasad
approved these changes
Apr 6, 2023
Collaborator
Author
|
Should we maybe make the arguments after the callback into an object to allow for non-breaking changes later? |
Member
Good idea, let's do it! |
AbhiPrasad
approved these changes
Apr 6, 2023
Collaborator
Author
|
Oops, this is currently incorrect. If we want to reuse an existing domain/context, we can just call the callback |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR extends
runWithAsyncContextonAsyncContextStrategyto allow reuse of existing context rather than creating a new sub-context.I've also added more jsdocs since the functions are getting more complex.