fix(e2e): Fix various issues with concurrent E2E and Canary tests #7805
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
size-limit report 📦
|
lforst
force-pushed
the
fix-async-canary-tests
branch
from
36386f8 to
8641c99
Compare
lforst
force-pushed
the
fix-async-canary-tests
branch
from
aa354cf to
e093d0f
Compare
lforst
changed the title
lforst
commented
Apr 11, 2023
| @@ -20,7 +20,7 @@ jobs: | |||
| job_canary_test: | |||
| name: Canary Tests | |||
| runs-on: ubuntu-20.04 | |||
| timeout-minutes: 30 | |||
| timeout-minutes: 60 | |||
There was a problem hiding this comment.
These tests are friggin slow for some reason
AbhiPrasad
approved these changes
Apr 11, 2023
lforst
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #7806
Seems like canary tests are actually broken for the canary version of Next.js (https://github.com/getsentry/sentry-javascript/actions/runs/4669052732/jobs/8266973383#step:7:6156) but this at least PR fixes the issues with our CI.
There are multiple layers that this PR fixes:
BASE_PORTto all test, along with aPORT_MODULOand aPORT_GAP. By doingBASE_PORT + PORT_MODULO + PORT_GAP * xwherexequals an arbitrary number we can avoid port clashes along thexaxis across parallel tests.yarn installcalls will write to the same cache and corrupt it. We fix this by creating individual yarn cache folders for each build command and purging them after the tests are done.