Skip to content

feat(replay): Remove unused debug statements #8167

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
billyvg merged 2 commits into from
May 25, 2023
Merged

feat(replay): Remove unused debug statements #8167

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
8938e6e
feat(replay): Remove unused debug statements
billyvg May 19, 2023
00060ff
Merge branch 'develop' into feat-replay-remove-debug-statement
billyvg May 23, 2023
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
27 changes: 0 additions & 27 deletions packages/replay/src/coreHandlers/handleGlobalEvent.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,4 +1,3 @@
import { addBreadcrumb } from '@sentry/core';
import type { Event, EventHint } from '@sentry/types';
import { logger } from '@sentry/utils';

Expand Down Expand Up @@ -50,13 +49,6 @@ export function handleGlobalEventListener(
event.tags = { ...event.tags, replayId: replay.getSessionId() };
}

if (__DEBUG_BUILD__ && replay.getOptions()._experiments.traceInternals && isErrorEvent(event)) {
const exc = getEventExceptionValues(event);
addInternalBreadcrumb({
message: `Tagging event (${event.event_id}) - ${event.message} - ${exc.type}: ${exc.value}`,
});
}

// In cases where a custom client is used that does not support the new hooks (yet),
// we manually call this hook method here
if (afterSendHandler) {
Expand All @@ -67,22 +59,3 @@ export function handleGlobalEventListener(
return event;
};
}

function addInternalBreadcrumb(arg: Parameters<typeof addBreadcrumb>[0]): void {
const { category, level, message, ...rest } = arg;

addBreadcrumb({
category: category || 'console',
level: level || 'debug',
message: `[debug]: ${message}`,
...rest,
});
}

function getEventExceptionValues(event: Event): { type: string; value: string } {
return {
type: 'Unknown',
value: 'n/a',
...(event.exception && event.exception.values && event.exception.values[0]),
};
}