fix(nextjs): Request for no HSTS in tunnel route endpoint #8936
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Lms24
approved these changes
Sep 4, 2023
mdtro
approved these changes
Sep 5, 2023
AbhiPrasad
approved these changes
Sep 5, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #8931
Since the tunnel route usually goes through user's domains and our ingest endpoint has HSTS we were unintentionally promoting user's requests which are unrelated to Sentry to https. This PR fixes that by setting the
hsts=0query param on the tunnel request to the ingest endpoint which will disable hsts for the responses as implemented in https://github.com/getsentry/ops/pull/7832.Should wait for https://github.com/getsentry/ops/pull/7832 to land before merging.