-
-
Notifications
You must be signed in to change notification settings - Fork 1.7k
feat(vercel-edge): add Vercel Edge Runtime package #9041
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
3a2032e
to
dafa758
Compare
|
||
"compilerOptions": { | ||
// should include all types from `./tsconfig.json` plus types for all test frameworks used | ||
"types": ["node", "jest"] |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
l: is this the thing that's still left to figure out or can we use "@edge-runtime/types"
instead of node here?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Yup this is part of the todo raised here
sentry-javascript/packages/vercel-edge/jest.config.js
Lines 5 to 6 in 1fdca16
// TODO: Fix tests to work with the Edge environment | |
// testEnvironment: '@edge-runtime/jest-environment', |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Nice, LGTM!
"engines": { | ||
"node": ">=8" | ||
}, |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
l: Probably not too important but is this even relevant for edge?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I'm going to set this to >=16
, same as what the edge runtime itself uses https://github.com/vercel/edge-runtime/blob/b28aa3b4f671e39ea19b4f70c1d695010b06ab7e/packages/vm/package.json#L26C19-L26C19
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Actually wait I'm not, let's stick with making this the same as nextjs for now.
cebc349
to
4534333
Compare
4534333
to
320c7aa
Compare
ref #8087
This PR adds a
@sentry/vercel-edge
SDK that can be used by our Next.js or Sveltekit SDKs for edge runtime support.People can also use this standalone
There is a TODO to figure out how to test this with edge runtime environment, but I'll address this in a follow up PR.