Skip to content

docs: Fix comments describing different import styles in readme #9081

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Sep 21, 2023
Merged

docs: Fix comments describing different import styles in readme #9081

merged 1 commit into from
Sep 21, 2023

Conversation

lforst
Copy link
Contributor

@lforst lforst commented Sep 21, 2023

CJS/ESM has nothing to do with ES5 or ES6

@lforst lforst requested review from mydea and AbhiPrasad September 21, 2023 06:17
mydea
mydea approved these changes Sep 21, 2023
View reviewed changes
Copy link
Member

@mydea mydea left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

actually also noticed this sometime recently and thought the same, good improvement!

@lforst lforst merged commit ef2ed6b into develop Sep 21, 2023
@lforst lforst deleted the lforst-fix-readmes-import-styles branch September 21, 2023 12:00
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mydea mydea mydea approved these changes

@AbhiPrasad AbhiPrasad Awaiting requested review from AbhiPrasad

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@lforst @mydea