-
-
Notifications
You must be signed in to change notification settings - Fork 184
feat(crashpad): add option to delay shutdown until crash report upload completes (Linux) #1153
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
|
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## master #1153 +/- ##
==========================================
- Coverage 82.67% 82.63% -0.04%
==========================================
Files 53 53
Lines 7954 7959 +5
Branches 1246 1246
==========================================
+ Hits 6576 6577 +1
- Misses 1264 1268 +4
Partials 114 114 |
# Conflicts: # CHANGELOG.md # src/backends/sentry_backend_crashpad.cpp # src/sentry_options.c # src/sentry_options.h # tests/test_integration_crashpad.py
Do we already want to add the dockerfile & docker-compose files to the repo for posterity, or should we just leave them in the PR description as-is (until we add a proper Docker test into our CI testing setup) |
I think it is enough to have it here. |
Co-authored-by: Mischan Toosarani-Hausberger <[email protected]>
In some scenarios, waiting for the upload to complete makes more sense than trying to quickly kill the crashed process.
Crashpad PR getsentry/crashpad#121
We start by providing this for Linux, since this is the most common use-case for this kind of wait-before-shutdown behavior. If the need arises, we can reconsider adding it for other platforms as well.
add test(s)<- manually tested->
we can try getting the Docker testing setup into CI as well<- out of scope for this PRcrashpad-wait-for-upload
option sentry-docs#13117Manual testing
Testing in CI is tricky, so we opted to test this on a local Docker setup instead. Below are the example
Dockerfile
anddocker-compose.yml
that we used to test this featuredockerfile
docker-compose.yml