Skip to content

Replace findUrlFactory with findUriFactory for Psr17FactoryDiscovery #1239

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Sep 7, 2021

Conversation

gclove
Copy link
Contributor

@gclove gclove commented Sep 6, 2021

https://github.com/php-http/discovery/blob/master/src/Psr17FactoryDiscovery.php#L125-L135

    /**
     * @return UriFactoryInterface
     *
     * @throws Exception\NotFoundException
     *
     * @deprecated This will be removed in 2.0. Consider using the findUriFactory() method.
     */
    public static function findUrlFactory()
    {
        return static::findUriFactory();
    }

@gclove
Copy link
Contributor Author

gclove commented Sep 6, 2021

Sorry, this change is from php-http/discovery 1.11.0 .

php-http/discovery#181

@gclove gclove closed this Sep 6, 2021
@ste93cry
Copy link
Contributor

ste93cry commented Sep 6, 2021

I think there is no problem in bumping the minimum required version to 1.11, if it makes it easier to then also support the next major 😉

@gclove gclove reopened this Sep 7, 2021
@gclove
Copy link
Contributor Author

gclove commented Sep 7, 2021

Thank you, I actually think so too 😂
May you help me re-run the CI workflows check?

@ste93cry ste93cry modified the milestones: 3.3, 3.4 Sep 7, 2021
@ste93cry ste93cry changed the base branch from master to develop September 7, 2021 07:47
@ste93cry
Copy link
Contributor

ste93cry commented Sep 7, 2021

Thank you for the contribution!

@ste93cry ste93cry merged commit 9abad10 into getsentry:develop Sep 7, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants