Skip to content

Django Integration complex url regex pattern cleanup #1527

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
PeterW-LWL opened this issue Jul 29, 2022 · 2 comments · Fixed by #1773
Closed

Django Integration complex url regex pattern cleanup #1527

PeterW-LWL opened this issue Jul 29, 2022 · 2 comments · Fixed by #1773
Assignees
Labels
Integration: Django Triaged Has been looked at recently during old issue triage

Comments

@PeterW-LWL
Copy link

Problem Statement

When using pythons sentry_sdk with Django and DjangoCMS using the default configuration for the DjangoIntegration I get a transactions {slug},w/]+)/.
This comes from the complex regex '^(?P<slug>[$\\-_.+!*(),\\w//]+)/$' which comes from DjangoCMS urls.py constants.py.

I expect even a complex regex like the above to get cleaned to just /{slug}/

Solution Brainstorm

Improve the regex filter in


Maybe even add a spezial case for this complex regex from DjangoCMS.

@sl0thentr0py sl0thentr0py self-assigned this Jul 29, 2022
mgaligniana added a commit to mgaligniana/sentry-python that referenced this issue Dec 5, 2022
mgaligniana added a commit to mgaligniana/sentry-python that referenced this issue Dec 5, 2022
mgaligniana added a commit to mgaligniana/sentry-python that referenced this issue Dec 5, 2022
mgaligniana added a commit to mgaligniana/sentry-python that referenced this issue Dec 5, 2022
mgaligniana added a commit to mgaligniana/sentry-python that referenced this issue Dec 5, 2022
mgaligniana added a commit to mgaligniana/sentry-python that referenced this issue Dec 5, 2022
mgaligniana added a commit to mgaligniana/sentry-python that referenced this issue Dec 5, 2022
mgaligniana added a commit to mgaligniana/sentry-python that referenced this issue Mar 12, 2023
@sentrivana sentrivana assigned sentrivana and unassigned sl0thentr0py Jun 7, 2023
@sentrivana
Copy link
Contributor

sentrivana commented Oct 10, 2023

Reopening this since we'll be reverting the related PR. See #2392 (comment) for more info.

@sentrivana sentrivana reopened this Oct 10, 2023
@antonpirker antonpirker added the Triaged Has been looked at recently during old issue triage label Dec 11, 2023
@antonpirker antonpirker added this to the Django update milestone Jun 7, 2024
@antonpirker antonpirker removed this from the Django update milestone Jun 20, 2024
@sentrivana sentrivana removed their assignment Dec 10, 2024
@antonpirker antonpirker self-assigned this Mar 20, 2025
@antonpirker
Copy link
Member

As this is about transaction names and we are in the middle of switching the performance instrumentation (the part in the SDK that creates transactions) to OpenTelemetry, this problem will be solved in the next major, because then the Sentry SDK will use OpenTelementry under the hood to create those transactions and OpenTelementry will set those transaction names.

@antonpirker antonpirker closed this as not planned Won't fix, can't repro, duplicate, stale Mar 20, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Integration: Django Triaged Has been looked at recently during old issue triage
Projects
None yet
Development

Successfully merging a pull request may close this issue.

4 participants