-
Notifications
You must be signed in to change notification settings - Fork 541
Django Integration complex url regex pattern cleanup #1527
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Comments
Reopening this since we'll be reverting the related PR. See #2392 (comment) for more info. |
As this is about transaction names and we are in the middle of switching the performance instrumentation (the part in the SDK that creates transactions) to OpenTelemetry, this problem will be solved in the next major, because then the Sentry SDK will use OpenTelementry under the hood to create those transactions and OpenTelementry will set those transaction names. |
Problem Statement
When using pythons
sentry_sdk
with Django and DjangoCMS using the default configuration for theDjangoIntegration
I get a transactions{slug},w/]+)/
.This comes from the complex regex
'^(?P<slug>[$\\-_.+!*(),\\w//]+)/$'
which comes from DjangoCMS urls.py constants.py.I expect even a complex regex like the above to get cleaned to just
/{slug}/
Solution Brainstorm
Improve the regex filter in
sentry-python/sentry_sdk/integrations/django/transactions.py
Line 48 in 9857bc9
Maybe even add a spezial case for this complex regex from DjangoCMS.
The text was updated successfully, but these errors were encountered: