-
Notifications
You must be signed in to change notification settings - Fork 544
feat(huey): add Huey Integration #1555
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat(huey): add Huey Integration #1555
Conversation
4a9dd8f
to
1f76978
Compare
@sl0thentr0py, @antonpirker any plans to get this reviewed? |
Hey @Zhenay ! |
Looking forward to using this! |
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
Hey @Zhenay ! Could you please follow the steps in this error message here to make the PR ready for testing: https://github.com/getsentry/sentry-python/actions/runs/3437030024/jobs/5731266278 Thanks! |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Just some cosmetic changes. If those are made and all the tests are green I will create a sample huey setup and give it a spin. (Tomorrow Friday, I am not in front of a computer, so I will be back here on Monday)
did not want to approve but to request changes.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Before I clicked wrong. So please make the changes mentioned in the comments in the PR.
When the changes are made and all the tests are green I will setup a sample huey project and give it a spin.
(I am not in front of a keyboard tomorrow (Friday) so I will be back here on Monday.)
Hey @antonpirker |
Hey @Zhenay ! I have now set up a simple demo app and everything looks good. I have the spans for the enqueuing/submitting of tasks: And also the span for the task itself I added a little check in your branch to only send sensitive date (the arguments and kwargs of the task) when the option "send_default_pii" is set to true. Because there could be all sorts of sensitive data (passwords, email adresses, names, ... in there) and this data should never be sent by default. |
Hey @Zhenay ! In your opinion, is this ready to be merged and shipped? FYI: The next release will be in around 2 weeks or so. Oh, and if you send me your shipping address (and t-shirt size) I can see If I can send you some swag as a little thank you. (send it to anton,[email protected]) |
Hey, @antonpirker! I suppose it can be merged. If any bugs are reported, I will be glad to fix them. |
Here you go! Thanks again! |
I couldn't find any reference to huey under https://docs.sentry.io/platforms/python/guides/django/configuration/integrations/, is it normal? |
Are there any plans to update the documentation to include a huey integration? |
Add support for the Huey Task Queue https://huey.readthedocs.io/en/latest/
See #195