Skip to content

feat(falcon): Update of Falcon Integration - #1733

Merged
antonpirker merged 21 commits into
masterfrom
antonpirker/falcon3
Feb 17, 2023
Merged

feat(falcon): Update of Falcon Integration#1733
antonpirker merged 21 commits into
masterfrom
antonpirker/falcon3

Conversation

@antonpirker

@antonpirker antonpirker commented Nov 10, 2022 •
edited
Loading

Copy link
Copy Markdown
Contributor

Made Falcon integration support version 3.0.1.
Also added new Falcon versions to the test suite.

Used to be this PR: #1297

Co-authored-by: bartolootrit bartolootrit@users.noreply.github.com

@vercel

vercel Bot commented Nov 10, 2022 •
edited
Loading

Copy link
Copy Markdown

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Updated
sentry-python ✅ Ready (Inspect) Visit Preview Nov 10, 2022 at 2:30PM (UTC)

@antonpirker antonpirker mentioned this pull request Nov 10, 2022
Merged
@antonpirker antonpirker self-assigned this Nov 10, 2022
sl0thentr0py
sl0thentr0py requested changes Nov 10, 2022
View reviewed changes
Comment thread sentry_sdk/integrations/falcon.py
dannyhajj
dannyhajj reviewed Nov 23, 2022
View reviewed changes
Comment thread sentry_sdk/integrations/falcon.py
# and `falcon.API` to `falcon.App`
try:
import falcon.app # type: ignore
import falcon.app_helpers # type: ignore

@dannyhajj dannyhajj Nov 23, 2022

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It would be preferable to attempt to import falcon.app_helpers first, then import falcon.api_helpers if the first fails.
Otherwise, the current code will keep complaining with deprecation warnings that api_helpers has been renamed.

@github-actions

github-actions Bot commented Dec 18, 2022

Copy link
Copy Markdown
Contributor

This pull request has gone three weeks without activity. In another week, I will close it.

But! If you comment or otherwise update it, I will reset the clock, and if you label it Status: Backlog or Status: In Progress, I will leave it alone ... forever!

"A weed is but an unloved flower." ― Ella Wheeler Wilcox 🥀

@github-actions github-actions Bot closed this Dec 25, 2022
@sl0thentr0py sl0thentr0py reopened this Jan 3, 2023
@antonpirker

antonpirker commented Jan 25, 2023

Copy link
Copy Markdown
Contributor Author

Hey @bartolootrit !

Sorry for the whole thing taking so long.
Could you have a look at the failing code cov? The goal would be to have at least a test coverage of 65% of the falcon integration. Could you add those tests? (If you are not allowed to push changes to my branch please just create a fork)

@bartolootrit

bartolootrit commented Jan 30, 2023

Copy link
Copy Markdown
Contributor

Could you add those tests? (If you are not allowed to push changes to my branch please just create a fork)

I'll try

@antonpirker

antonpirker commented Feb 6, 2023

Copy link
Copy Markdown
Contributor Author

Hey @bartolootrit !
Thanks for your continued work.
If you need help with running the tests locally, than I am here to help

@antonpirker antonpirker changed the title Update of Falcon Integration feat(falcon): Update of Falcon Integration Feb 6, 2023
@antonpirker

antonpirker commented Feb 17, 2023

Copy link
Copy Markdown
Contributor Author

Hey @bartolootrit !
Everything looks great now.
What about the comment from @dannyhajj about the order of imports above? Is this something we need to address, or can we merge this as is?

@antonpirker
antonpirker enabled auto-merge (squash) February 17, 2023 10:07
antonpirker and others added 6 commits February 17, 2023 12:00
@antonpirker
Mocking http requests instead of doing real ones.
1765639
@antonpirker
Removed obsolete comment
6418e1f
@antonpirker
Removed usage of httpbin.org and where possible replaced by a mock. (…
8469785 
…one instance this was impossible to we use httpstat.us now.
@bartolootrit @getsentry-bot
@antonpirker getsentry-bot
Falcon 3 integration code coverage (#1890)
f4338f3 
* release: 1.15.0

* Made nice changelog

* Falcon 3 integration installation check

---------

Co-authored-by: getsentry-bot <bot@sentry.io>
Co-authored-by: Anton Pirker <anton.pirker@sentry.io>
Co-authored-by: getsentry-bot <bot@getsentry.com>
@antonpirker
Merge branch 'antonpirker/fix-httpx-tests' into antonpirker/falcon3
f051141
@antonpirker
Merge branch 'antonpirker/falcon3' of github.com:getsentry/sentry-pyt…
e3f14a8 
…hon into antonpirker/falcon3
@antonpirker
antonpirker merged commit f62c83d into master Feb 17, 2023
@antonpirker
antonpirker deleted the antonpirker/falcon3 branch February 17, 2023 12:32
@MarkKoz MarkKoz mentioned this pull request Mar 13, 2023
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@sl0thentr0py sl0thentr0py sl0thentr0py approved these changes
+2 more reviewers
@dannyhajj dannyhajj dannyhajj left review comments
@bartolootrit bartolootrit bartolootrit left review comments
Reviewers whose approvals may not affect merge requirements

Assignees

@antonpirker antonpirker

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

4 participants

@antonpirker @bartolootrit @dannyhajj @sl0thentr0py