feat(arq): add arq integration

[Zhenay]

Add support for arq https://arq-docs.helpmanual.io/

See #1728

[antonpirker]

Hey @Zhenay !

Thanks for the great work. Looks good!
The coverage report is somehow misleading, because I thing it has way more coverage but because it is async code the coverage is calculated wrong.

I will create a test project for this today.

Could you try to find out why the coverage is wrong? This is the code I used for local coverage measurements:

coverage erase
./scripts/runtox.sh "py3.10-arq" --cov=tests --cov=sentry_sdk --cov-report= --cov-branch
coverage combine .coverage*
coverage html

[Zhenay]

Hey @antonpirker!

I'll take a look at the coverage problems this evening.

[antonpirker]

One thing @Zhenay :

There is the possibility of distributed tracing (to see performance data from the python process that put a job into the queue combined with the performance data of the job being executed by the worker)

In rq the trace information is put into the jobs meta data when enqueuing the job:
https://github.com/getsentry/sentry-python/blob/master/sentry_sdk/integrations/rq.py#L109-L111

and then fetched from this meta again when the job is executed:
https://github.com/getsentry/sentry-python/blob/master/sentry_sdk/integrations/rq.py#L67-L72

Is there something like this in arq? Would be a great feature to have.

[Zhenay]

@antonpirker, unfortunately arq jobs hasn't meta data.

I can make a pr to arq. But suppose it will be more chances to be accepted, if this is merged.

[antonpirker]

@antonpirker, unfortunately arq jobs hasn't meta data.

I can make a pr to arq. But suppose it will be more chances to be accepted, if this is merged.

Ok, it is just a nice to have for now, so we can move forward without it.

[Zhenay]

The coverage was wrong because I had forgot to add pytest-asyncio for arq into tox.ini.

[antonpirker]

I have now made a small fix to your PR to clone the sentry hub. Because before it happened that the spans that where created when doing a http request (I used the demo from the arq website) then multiple downloads (from multiple jobs) showed up under the same job in Sentry.
But now everything looks good.

[Zhenay]

Great, should I do anything else?

[antonpirker]

No, I think its good.
I have merged it and it will release it soon.

[antonpirker]

Oh @Zhenay you can add a PR to https://github.com/getsentry/sentry-docs for a documentation on how to use the integration. Something short like this: https://docs.sentry.io/platforms/python/configuration/integrations/sqlalchemy/

Just that have something to copy and paste, to be up and running in no time. Would be great!

[antonpirker]

Oh, and have you already sent me your shipping address (for the Huey integration)? If not please send me your shipping address and t-shirt size to [email protected]

Thanks!

[Zhenay]

I'll create PR to docs soon.
Yes, I've already sent the address.