-
-
Notifications
You must be signed in to change notification settings - Fork 347
chore(rn-sample): Upgrade to React Native 0.79.2 #4806
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Merged
Changes from 9 commits
Commits
Show all changes
13 commits
Select commit
Hold shift + click to select a range
ef5cfd4
chore(rn-sample): Upgrade to React Native 0.79.2
krystofwoldrich 97bc5bc
downgrade rn to 0.78.2 to fix types issue
krystofwoldrich 921136d
fix clang format
krystofwoldrich 4c4daeb
revert RN bump in core package
krystofwoldrich 9c6465b
patch react native webview to work with rn 0.79
krystofwoldrich 4d109ff
Merge remote-tracking branch 'origin/main' into kw-upgrade-to-rn-79
krystofwoldrich f89333f
add missing plugin file
krystofwoldrich 53ad737
avoid install failure on post install failure
krystofwoldrich 1b7fcb4
fix ios
krystofwoldrich e7144d3
fix patch
krystofwoldrich f7fecab
fix patch 2
krystofwoldrich 2535d45
remove patch, disable webview
krystofwoldrich 2c841b2
Merge branch 'main' into kw-upgrade-to-rn-79
antonis File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.
Oops, something went wrong.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -1,3 +1,10 @@ | ||
nmHoistingLimits: workspaces | ||
|
||
nodeLinker: node-modules | ||
|
||
plugins: | ||
# The plugin source file has to be present in the repository, otherwise it would have to be install | ||
# before running yarn install by the user/ci... | ||
- .yarn/plugins/plugin-after-install.js | ||
|
||
afterInstall: yarn postinstall |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
|
@@ -33,6 +33,7 @@ local.properties | |
.cxx/ | ||
*.keystore | ||
!debug.keystore | ||
.kotlin/ | ||
|
||
# node.js | ||
# | ||
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -1,9 +1,15 @@ | ||
source 'https://rubygems.org' | ||
|
||
# You may use http://rbenv.org/ or https://rvm.io/ to install and use this version | ||
ruby "3.3.0" | ||
# ruby "3.4.0" | ||
|
||
gem 'cocoapods', '1.15.2' | ||
gem 'activesupport', '>= 6.1.7.5', '< 7.1.0' | ||
gem 'fastlane', '2.220.0' | ||
gem 'xcodeproj', '< 1.26.0' | ||
|
||
# Ruby 3.4.0 has removed some libraries from the standard library. | ||
gem 'bigdecimal' | ||
gem 'logger' | ||
gem 'benchmark' | ||
gem 'mutex_m' |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Binary file modified
BIN
-19.5 KB
(69%)
samples/react-native/android/gradle/wrapper/gradle-wrapper.jar
Binary file not shown.
2 changes: 1 addition & 1 deletion
2
samples/react-native/android/gradle/wrapper/gradle-wrapper.properties
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
8 changes: 6 additions & 2 deletions
8
samples/react-native/ios/sentryreactnativesample/AppDelegate.h
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -1,6 +1,10 @@ | ||
#import <RCTAppDelegate.h> | ||
#import <RCTDefaultReactNativeFactoryDelegate.h> | ||
#import <RCTReactNativeFactory.h> | ||
#import <UIKit/UIKit.h> | ||
|
||
@interface AppDelegate : RCTAppDelegate | ||
@interface AppDelegate : RCTDefaultReactNativeFactoryDelegate <UIApplicationDelegate> | ||
|
||
@property (nonatomic, strong, nonnull) UIWindow *window; | ||
@property (nonatomic, strong, nonnull) RCTReactNativeFactory *reactNativeFactory; | ||
|
||
@end |
Oops, something went wrong.
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Should we install the plugin in the workflow or commit it to avoid the CI failure?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Ahh, my bad, I've not push the plugin file, when the file is present it should be picked up automatically without installation, which was my goal, as having to install plugin before using
yarn install
would be terrible developer experience.