Implements NamespacedPoolInterface for TraceableCacheAdapterForV3 #927
+84
−1
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Yep, they should become fixed once #928 is merged. |
|
@VincentLanglet we fixed the unrelated errors, but there still a few CI failures left. |
VincentLanglet
force-pushed
the
namespacePool
branch
from
043fe9e to
c9fd7dc
Compare
VincentLanglet
force-pushed
the
namespacePool
branch
from
fbbdc5c to
760895e
Compare
I used another strategy, tests are passing now :) |
|
Any change we can add a new test? Happy to take care of this. |
I added a test (and fixed my code) |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Looking at the failure, I don't think they are related... I'm not sure why I have them.