feat(nextjs): Switch to injecting instrumentation-client.ts
#918
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## master #918 +/- ##
==========================================
+ Coverage 51.79% 52.00% +0.21%
==========================================
Files 53 53
Lines 3657 3665 +8
Branches 854 867 +13
==========================================
+ Hits 1894 1906 +12
+ Misses 1762 1629 -133
- Partials 1 130 +129
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
s1gr1d
approved these changes
Mar 27, 2025
src/nextjs/templates.ts
Outdated
| // eslint-disable-next-line @typescript-eslint/restrict-template-expressions | ||
| return `${primer} | ||
| return `// This file configures the initialization of Sentry on the client. | ||
| // The added here will be used whenever a users loads a page in their browser. |
There was a problem hiding this comment.
good catch thank you!
test/nextjs/templates.test.ts
Outdated
| // https://docs.sentry.io/platforms/javascript/guides/nextjs/ | ||
| expect(template).toMatchInlineSnapshot(` | ||
| "// This file configures the initialization of Sentry on the client. | ||
| // The added here will be used whenever a users loads a page in their browser. |
There was a problem hiding this comment.
Same here - is it "added config"?
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The SDK now supports instrumentation-client.ts which is an experimental Next.js feature that we want to make use of for turbopack.
getsentry/sentry-javascript#15705