fix(issues): Return 400 for InvalidSearchQuery during bulk delete and update (#128414)

When a bulk issue delete or update request contains an invalid search
query—for example `?query=issue:155261377` where a numeric group id is
passed to the `issue:` filter instead of a qualified short
id—`format_search_filter` raises an `InvalidSearchQuery` while building
the Snuba query.

Because this happens inside `search_fn` rather than
`parse_and_convert_issue_search_query`, the exception was not translated
to a `ValidationError`. Both `schedule_tasks_to_delete_groups` and
`update_groups_with_search_fn` only caught `ValidationError`, allowing
`InvalidSearchQuery` to bubble up to the top-level endpoint exception
handler, which logged an error traceback and returned HTTP 500.

This change:
- Catches `InvalidSearchQuery` in `schedule_tasks_to_delete_groups` and
returns an HTTP 400 response with `{"detail": "Invalid search query."}`.
- Catches `InvalidSearchQuery` in `update_groups_with_search_fn` and
returns an HTTP 400 response with `{"detail": "Invalid search query."}`
without logging an error to Sentry.
- Uses a generic client-safe error message rather than echoing exception
internals into the response.

<!--

  Sentry employees and contractors can delete or ignore the following.

-->

### Legal Boilerplate

Look, I get it. The entity doing business as "Sentry" was incorporated
in the State of Delaware in 2015 as Functional Software, Inc. and is
gonna need some rights from me in order to utilize my contributions in
this here PR. So here's the deal: I retain all rights, title and
interest in and to my contributions, and by keeping this boilerplate
intact I confirm that Sentry can use, modify, copy, and redistribute my
contributions, under Sentry's choice of terms.

<!-- SEER_FIXES_SENTRY_ISSUE -->
Fixes
[SENTRY-5Z50](https://sentry.sentry.io/issues/7805127888/?seerDrawer=true)
<!-- /SEER_FIXES_SENTRY_ISSUE -->

<sub>`@sentry <feedback>`: Autofix iterates on these changes</sub>
<sub>`@sentry stop iterating`: Autofix stops iterating on this run</sub>

---------

Co-authored-by: sentry[bot] <39604003+sentry[bot]@users.noreply.github.com>
Co-authored-by: cvxluo <27893746+cvxluo@users.noreply.github.com>
Co-authored-by: Charlie Luo <cvxluo@gmail.com>
Co-authored-by: Francis Genet <francis.genet@gmail.com>

Author: 3 people

src/sentry/api/helpers/group_index/delete.py

@@ -18,6 +18,7 @@
 from sentry.apidocs.response_types import ValidationErrorResponse
 from sentry.deletions.defaults.group import GROUP_CHUNK_SIZE
 from sentry.deletions.tasks.groups import delete_groups_for_project
+from sentry.exceptions import InvalidSearchQuery
 from sentry.models.group import Group, GroupStatus
 from sentry.models.groupinbox import GroupInbox
 from sentry.models.project import Project
@@ -187,6 +188,8 @@ def schedule_tasks_to_delete_groups(
             )
         except ValidationError as exc:
             return Response({"detail": str(exc)}, status=400)
+        except InvalidSearchQuery:
+            return Response({"detail": "Invalid search query."}, status=400)
 
         group_list = list(cursor_result)
 

src/sentry/api/helpers/group_index/update.py

@@ -23,6 +23,7 @@
 from sentry.api.serializers import serialize
 from sentry.api.serializers.models.actor import ActorSerializer, ActorSerializerResponse
 from sentry.api.serializers.models.groupactionlogentry import get_serialized_activity_items
+from sentry.exceptions import InvalidSearchQuery
 from sentry.hybridcloud.rpc import coerce_id_from
 from sentry.integrations.tasks.kick_off_status_syncs import kick_off_status_syncs
 from sentry.issues.action_log import (
@@ -332,6 +333,10 @@ def update_groups_with_search_fn(
             return Response(
                 {"detail": "Invalid query. Error getting group ids and group list"}, status=400
             )
+        except InvalidSearchQuery:
+            # Raised while building the Snuba query (e.g. `issue:` with an
+            # invalid short ID). This is a client error; don't report it.
+            return Response({"detail": "Invalid search query."}, status=400)
 
         group_list = list(cursor_result)