Repository navigation
fix(issues): Return 400 for InvalidSearchQuery during bulk delete and update - #128414
Merged
cvxluo merged 6 commits intoOct 21, 2026
Merged
Conversation
…k delete and update
cvxluo
reviewed
Oct 21, 2026
| except ValidationError as exc: | ||
| return Response({"detail": str(exc)}, status=400) | ||
| except InvalidSearchQuery: | ||
| # InvalidSearchQuery can be raised while building the Snuba query |
…n invalid search query Co-authored-by: sentry[bot] <39604003+sentry[bot]@users.noreply.github.com>
cvxluo
approved these changes
Oct 21, 2026
cvxluo
deleted the
seer/fix/issues-bulk-delete-invalid-search-query-400
branch
October 21, 2026 22:45
This branch was successfully deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
When a bulk issue delete or update request contains an invalid search query—for example
?query=issue:155261377where a numeric group id is passed to theissue:filter instead of a qualified short id—format_search_filterraises anInvalidSearchQuerywhile building the Snuba query.Because this happens inside
search_fnrather thanparse_and_convert_issue_search_query, the exception was not translated to aValidationError. Bothschedule_tasks_to_delete_groupsandupdate_groups_with_search_fnonly caughtValidationError, allowingInvalidSearchQueryto bubble up to the top-level endpoint exception handler, which logged an error traceback and returned HTTP 500.This change:
InvalidSearchQueryinschedule_tasks_to_delete_groupsand returns an HTTP 400 response with{"detail": "Invalid search query."}.InvalidSearchQueryinupdate_groups_with_search_fnand returns an HTTP 400 response with{"detail": "Invalid search query."}without logging an error to Sentry.Legal Boilerplate
Look, I get it. The entity doing business as "Sentry" was incorporated in the State of Delaware in 2015 as Functional Software, Inc. and is gonna need some rights from me in order to utilize my contributions in this here PR. So here's the deal: I retain all rights, title and interest in and to my contributions, and by keeping this boilerplate intact I confirm that Sentry can use, modify, copy, and redistribute my contributions, under Sentry's choice of terms.
Fixes SENTRY-5Z50
@sentry <feedback>: Autofix iterates on these changes@sentry stop iterating: Autofix stops iterating on this run