Skip to content

Allow specifying projects for release deploys #33648

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
BYK opened this issue Apr 15, 2022 · 9 comments · Fixed by #35916
Closed

Allow specifying projects for release deploys #33648

BYK opened this issue Apr 15, 2022 · 9 comments · Fixed by #35916

Comments

@BYK
Copy link
Member

BYK commented Apr 15, 2022

Problem Statement

We have a monorepo that houses 4+ projects. They are versioned by the common git SHA so they share the same release id. That said we don't necessarily deploy them all at the same time.

I was trying to create a deploy per each project but seems like the create deploy API endpoint does not support passing individual projects (unlike the create release endpoint).

I'd love to be able to specify which projects the deploy was made for.

Solution Brainstorm

Seems like under the hood, Sentry supports this. Only missing thing is accepting an array of project slugs/ids in the API endpoint and respecting them here:

for project in projects:
ReleaseProjectEnvironment.objects.create_or_update(
release=release,
environment=env,
project=project,
values={"last_deploy_id": deploy.id},
)

Happy to submit a PR if this sounds good to the team.

@getsentry-release
Copy link

Routing to @getsentry/owners-releases-ui for triage. ⏲️

@getsentry-release
Copy link

Routing to @getsentry/workflow for triage. ⏲️

@fanley-sentry
Copy link

Hi @BYK how does this work for those that don't have this workflow? If they have micro services for example.

@BYK
Copy link
Member Author

BYK commented May 10, 2022

@fanley-sentry @Kobby-Bawuah It will work as usual when no projects are specified but will only limit to projects when some/any passed.

If they have micro services for example.

We also have microservices in the same repo which is why we have this issue exactly. I think you meant multi-repo setups?

@BYK
Copy link
Member Author

BYK commented May 10, 2022

I think this can easily be relevant for #34327

@github-actions
Copy link
Contributor

github-actions bot commented Jun 1, 2022

This issue has gone three weeks without activity. In another week, I will close it.

But! If you comment or otherwise update it, I will reset the clock, and if you label it Status: Backlog or Status: In Progress, I will leave it alone ... forever!


"A weed is but an unloved flower." ― Ella Wheeler Wilcox 🥀

@BYK
Copy link
Member Author

BYK commented Jun 6, 2022

@fanley-sentry please triage or ask further questions to clarify :)

@scttcper
Copy link
Member

scttcper commented Jun 6, 2022

@BYK if you're still interested in making a PR I can take a look, i've also added it to our backlog.

@fanley-sentry
Copy link

@BYK looking into this. Will follow up with questions if we have them. Thanks for suggesting and raising.

@snigdhas snigdhas linked a pull request Jun 22, 2022 that will close this issue
@github-actions github-actions bot locked and limited conversation to collaborators Jul 8, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

7 participants