-
-
Notifications
You must be signed in to change notification settings - Fork 4.3k
Allow specifying projects for release deploys #33648
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Comments
Routing to @getsentry/owners-releases-ui for triage. ⏲️ |
Routing to @getsentry/workflow for triage. ⏲️ |
Hi @BYK how does this work for those that don't have this workflow? If they have micro services for example. |
@fanley-sentry @Kobby-Bawuah It will work as usual when no projects are specified but will only limit to projects when some/any passed.
We also have microservices in the same repo which is why we have this issue exactly. I think you meant multi-repo setups? |
I think this can easily be relevant for #34327 |
This issue has gone three weeks without activity. In another week, I will close it. But! If you comment or otherwise update it, I will reset the clock, and if you label it "A weed is but an unloved flower." ― Ella Wheeler Wilcox 🥀 |
@fanley-sentry please triage or ask further questions to clarify :) |
@BYK if you're still interested in making a PR I can take a look, i've also added it to our backlog. |
@BYK looking into this. Will follow up with questions if we have them. Thanks for suggesting and raising. |
Problem Statement
We have a monorepo that houses 4+ projects. They are versioned by the common git SHA so they share the same release id. That said we don't necessarily deploy them all at the same time.
I was trying to create a deploy per each project but seems like the create deploy API endpoint does not support passing individual projects (unlike the create release endpoint).
I'd love to be able to specify which projects the deploy was made for.
Solution Brainstorm
Seems like under the hood, Sentry supports this. Only missing thing is accepting an array of project slugs/ids in the API endpoint and respecting them here:
sentry/src/sentry/api/endpoints/release_deploys.py
Lines 112 to 118 in 8213db2
Happy to submit a PR if this sounds good to the team.
The text was updated successfully, but these errors were encountered: