fix(cleanup): Move partition validation before environment setup#108404
Open
fix(cleanup): Move partition validation before environment setup#108404
Conversation
…revent test pollution Partition flag validation in `_cleanup()` was happening after `_validate_and_setup_environment()`, which sets `os.environ["_SENTRY_CLEANUP"]`. When validation raised a ClickException, the env var was left set, causing subsequent tests to skip error event deletion (the env var makes group deletion skip `ErrorEventsDeletionTask`).
github-actions
bot
added
the
Scope: Backend
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Fixes test pollution where
PartitionValidationTesttests in the cleanup command would leaveos.environ["_SENTRY_CLEANUP"]set, causing subsequent tests to fail.Reproduction:
Root cause:
_cleanup()called_validate_and_setup_environment()(which sets_SENTRY_CLEANUPenv var) before partition flag validation. When validation raised aClickException, the env var persisted and caused group deletion to skipErrorEventsDeletionTask, so error events were never deleted.Fix: Move partition validation before
_validate_and_setup_environment()so invalid input is rejected before any environment modifications.