chore(context engine): New RPC endpoint for project instrumentation details#108413
chore(context engine): New RPC endpoint for project instrumentation details#108413Mihir-Mavalankar wants to merge 4 commits intomasterfrom
Conversation
github-actions
bot
added
the
Scope: Backend
| "hasTraceMetrics": get_has_trace_metrics(project), | ||
| "hasLogs": get_has_logs(project), |
There was a problem hiding this comment.
are these two functions performant? thinking of case w/ orgs that have 1000+ projects
There was a problem hiding this comment.
The functions themselves are fast since they just check bit fields like project.flags.has_logs with an if statement but fetching a lot of projects can be problematic.
The rpc above get_organization_project_ids has the same pattern though. Maybe if we see timeouts we can revisit this?
JoshFerge
left a comment
JoshFerge
left a comment
There was a problem hiding this comment.
lgtm, only other thought is should we just just pass these in when we initialize the explorer task instead? or will this be conditionally called etc.
That would be preferable but eventually this is going to a daily cron task in Seer that calls this. So it won't be Sentry initializing this task. |
3 participants
PR Details