fix(servicehooks): Make servicehook updating idempotent#108415
Open
Christinarlong wants to merge 2 commits intomasterfrom
Open
fix(servicehooks): Make servicehook updating idempotent#108415Christinarlong wants to merge 2 commits intomasterfrom
Christinarlong wants to merge 2 commits intomasterfrom
Conversation
github-actions
bot
added
the
Scope: Backend
![sentry[bot]](https://avatars.githubusercontent.com/in/12637?s=60&v=4){kind=small}
![cursor[bot]](https://avatars.githubusercontent.com/in/1210556?s=60&v=4){kind=small}
Contributor
There was a problem hiding this comment.
Cursor Bugbot has reviewed your changes and found 1 potential issue.
Bugbot Autofix is OFF. To automatically fix reported issues with Cloud Agents, enable Autofix in the Cursor dashboard.
GabeVillalobos
approved these changes
Feb 18, 2026
Member
GabeVillalobos
left a comment
GabeVillalobos
left a comment
There was a problem hiding this comment.
@markstory Any idea why ServiceHook was given an explicit deletion task? The comment dates back to this PR #45656, but it's unclear why we have this behavior.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Fixes a
MultipleObjectsReturnederror increate_or_update_webhook_and_events_for_installationcaused by duplicateServiceHookrows for the same (installation_id, application_id) pair.Due to concurrency issues, some installations ended up with multiple ServiceHook objects. The previous implementation used update_or_create() and get(), which both fail when duplicates exist. This changes the function to a delete-and-recreate pattern, making it fully idempotent regardless of how many hooks exist.
Test info