Repository navigation
feat(gitlab): Add API pipleine flag - #112367
Merged
evanpurkhiser merged 1 commit intoApr 7, 2026
Merged
Conversation
github-actions
Bot
added
the
Scope: Backend
![sentry[bot]](https://avatars.githubusercontent.com/in/12637?s=60&v=4){kind=small}
| manager.add("organizations:scm-source-context", OrganizationFeature, FeatureHandlerStrategy.FLAGPOLE, api_expose=True) | ||
| # API-driven integration setup pipeline (per-provider rollout) | ||
| manager.add("organizations:integration-api-pipeline-github", OrganizationFeature, FeatureHandlerStrategy.FLAGPOLE, api_expose=True) | ||
| manager.add("organizations:integration-api-pipeline-gitlab", OrganizationFeature, FeatureHandlerStrategy.FLAGPOLE, api_expose=True) |
Contributor
There was a problem hiding this comment.
Bug: The new backend feature flag organizations:integration-api-pipeline-gitlab is exposed to the API but lacks the required frontend implementation, rendering it non-functional.
Severity: MEDIUM
Suggested Fix
Either remove the organizations:integration-api-pipeline-gitlab feature flag until the frontend implementation is ready, or add the required frontend code. This includes adding a 'gitlab' entry to the API_PIPELINE_FEATURE_FLAGS map and registering a gitlabIntegrationPipeline in the frontend pipeline registry.
Prompt for AI Agent
Review the code at the location below. A potential bug has been identified by an AI
agent.
Verify if this is a real issue. If it is, propose a fix; if not, explain why it's not
valid.
Location: src/sentry/features/temporary.py#L146
Potential issue: The new feature flag `organizations:integration-api-pipeline-gitlab` is
registered in the backend with `api_expose=True`, indicating it should be used by the
frontend. However, the corresponding frontend implementation is missing. The
`API_PIPELINE_FEATURE_FLAGS` map in
`static/app/views/settings/organizationIntegrations/addIntegration.tsx` lacks an entry
for 'gitlab'. This causes the `getApiPipelineProvider` function to return `null`,
forcing a fallback to the legacy popup-based integration flow. As a result, enabling the
feature flag has no effect on GitLab integration setup.
Did we get this right? 👍 / 👎 to inform future reviews.
JoshFerge
approved these changes
Apr 7, 2026
evanpurkhiser
deleted the
evanpurkhiser/feat-gitlab-add-api-pipleine-flag
branch
April 7, 2026 16:03
george-sentry
pushed a commit
that referenced
this pull request
Apr 9, 2026
Part of [VDY-39: GitLab: API-driven integration setup](https://linear.app/getsentry/issue/VDY-39/gitlab-api-driven-integration-setup)
3 tasks
This branch was successfully deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Part of VDY-39: GitLab: API-driven integration setup