Repository navigation
fix(lint): pass file lists to lint scripts as separate arguments - #128363
Merged
Merged
Conversation
scripts/lint.ts ran root and package lint scripts through pnpm run, which joins every path into one shell string. A change to a widely imported file makes CI lint thousands of impacted files, and pnpm crashes before linting starts. Running each script's command through pnpm exec keeps the paths as separate arguments.
github-actions
Bot
added
the
Scope: Frontend
natemoo-re
approved these changes
Oct 21, 2026
TkDodo
approved these changes
Oct 21, 2026
2 tasks done
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
scripts/lint.ts(#127203) runs root and package lint scripts throughpnpm run, which joins every path into one shell string, so a change to a widely imported file makes the impacted-files oxlint step crash before linting starts. This brings back the fix from #126758 by running each script's command throughpnpm execso paths stay separate arguments.