Skip to content

feat(investigations): Validate action request events - #128421

Merged
wedamija merged 5 commits into
masterfrom
danf/inv-fu-11-contract
Oct 21, 2026
Merged

wedamija merged 5 commits into
masterfrom
danf/inv-fu-11-contract

Conversation

@wedamija

Copy link
Copy Markdown
Member

Part of a series that adds follow-up actions to Seer investigations: when a run completes, Seer suggests one next step, and the user can apply a typed action, such as a monitor change, with one click.

Accept Seer's action request and withdrawal events, so Sentry can store what Seer suggests. Each action kind owns its payload contract, so new kinds don't change the shared one.

Part of a series that adds follow-up actions to Seer investigations: when a
run completes, Seer suggests one next step, and the user can apply a typed
action, such as a monitor change, with one click.

Accept Seer's action request and withdrawal events, so Sentry can store what
Seer suggests. Each action kind owns its payload contract, so new kinds don't
change the shared one.
@wedamija
wedamija requested review from a team as code owners October 21, 2026 19:24
@github-actions github-actions Bot added the Scope: Backend Automatically applied to PRs that change backend components label Oct 21, 2026
@wedamija
wedamija requested a review from billyvg October 21, 2026 19:25

@cursor cursor Bot left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Cursor Bugbot has reviewed your changes and found 1 potential issue.

Fix All in Cursor

❌ Bugbot Autofix is OFF. To automatically fix reported issues with cloud agents, enable autofix in the Cursor dashboard.

Reviewed by Cursor Bugbot for commit dc0b350. Configure here.

Comment thread src/sentry/investigations/services/action_kinds/__init__.py

@billyvg billyvg left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🤖 Review comments from Claude (AI agent), posted at @billyvg's request.

Comment thread src/sentry/investigations/services/action_kinds/update_detector.py
Comment thread src/sentry/investigations/services/action_kinds/update_detector.py
Comment thread src/sentry/investigations/services/action_kinds/update_detector.py Outdated
Comment thread src/sentry/investigations/contracts.py Outdated
Reject IDs and windows past their column limits, keep trim from fixing a malformed action, and log each dropped request once, on the apply path.
Store typed actions from the first ingest PR on, and type validated requests so callers don't cast.
Say what trim drops and why, now that the limits are policy.
Make the comments read plainly.
@wedamija
wedamija merged commit d3ea2af into master Oct 21, 2026
74 checks passed
@wedamija
wedamija deleted the danf/inv-fu-11-contract branch October 21, 2026 22:07
wedamija added a commit that referenced this pull request Oct 21, 2026
Part of a series that adds follow-up actions to Seer investigations:
when a run completes, Seer suggests one next step, and the user can
apply a typed action, such as a monitor change, with one click.

Save the requests Seer sends during and after a run, and keep them
current as Seer revises, withdraws, or replaces them, so Sentry always
shows Seer's latest suggestions.

Depends on #128421.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Scope: Backend Automatically applied to PRs that change backend components

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants