Repository navigation
fix(tests): Unregister options registered in test_deprecation - #128460
Merged
Merged
Conversation
test_custom_key registered override-cron and override-duration without cleanup, so test_no_new_legacy_options failed whenever both ran in the same process.
srest2021
marked this pull request as ready for review
October 21, 2026 22:00
cvxluo
approved these changes
Oct 21, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
DeprecationTest::test_custom_keyregisters theoverride-cronandoverride-durationoptions and never unregisters them. Whentest_no_new_legacy_optionsruns later on the same worker, it fails withNew options must have FLAG_AUTOMATOR_MODIFIABLE: ['override-cron', 'override-duration'].This only shows up when the shard split puts both files together, and then every re-run fails too. The fix unregisters both options when the test finishes.
First identified here: https://github.com/getsentry/sentry/actions/runs/39671002907/job/119469311970?pr=128416
and is blocking #128416