feat: Update Group.get_latest_event to use Snuba event

src/sentry/models/group.py

@@ -22,9 +22,7 @@
 from django.utils.translation import ugettext_lazy as _
 
 from sentry import eventtypes, tagstore
-from sentry.constants import (
-    DEFAULT_LOGGER_NAME, EVENT_ORDERING_KEY, LOG_LEVELS, MAX_CULPRIT_LENGTH
-)
+from sentry.constants import DEFAULT_LOGGER_NAME, LOG_LEVELS, MAX_CULPRIT_LENGTH
 from sentry.db.models import (
     BaseManager, BoundedBigIntegerField, BoundedIntegerField, BoundedPositiveIntegerField,
     FlexibleForeignKey, GzippedDictField, Model, sane_repr
@@ -407,20 +405,9 @@ def get_score(self):
         return type(self).calculate_score(self.times_seen, self.last_seen)
 
     def get_latest_event(self):
-        from sentry.models import Event
-
         if not hasattr(self, '_latest_event'):
-            latest_events = sorted(
-                Event.objects.filter(
-                    group_id=self.id,
-                ).order_by('-datetime')[0:5],
-                key=EVENT_ORDERING_KEY,
-                reverse=True,
-            )
-            try:
-                self._latest_event = latest_events[0]
-            except IndexError:
-                self._latest_event = None
+            self._latest_event = self.get_latest_event_for_environments()
+
         return self._latest_event
 
     def get_latest_event_for_environments(self, environments=()):

tests/sentry/api/endpoints/test_group_integration_details.py

@@ -2,26 +2,44 @@
 
 import six
 import mock
+from datetime import timedelta
+from django.utils import timezone
+import copy
 
 from sentry.integrations.example.integration import ExampleIntegration
 from sentry.integrations.exceptions import IntegrationError
 from sentry.models import Activity, ExternalIssue, GroupLink, Integration
 from sentry.testutils import APITestCase
 from sentry.utils.http import absolute_uri
+from sentry.testutils.factories import DEFAULT_EVENT_DATA
 
 
 class GroupIntegrationDetailsTest(APITestCase):
+    def setUp(self):
+        super(GroupIntegrationDetailsTest, self).setUp()
+        self.min_ago = timezone.now() - timedelta(minutes=1)
+        self.event = self.store_event(
+            data={
+                'event_id': 'a' * 32,
+                'timestamp': self.min_ago.isoformat()[:19],
+                'message': 'message',
+                'stacktrace': copy.deepcopy(DEFAULT_EVENT_DATA['stacktrace']),
+            },
+            project_id=self.project.id
+        )
+        self.group = self.event.group
+
     def test_simple_get_link(self):
         self.login_as(user=self.user)
         org = self.organization
-        group = self.create_group()
         integration = Integration.objects.create(
             provider='example',
             name='Example',
         )
         integration.add_organization(org, self.user)
 
-        path = u'/api/0/issues/{}/integrations/{}/?action=link'.format(group.id, integration.id)
+        path = u'/api/0/issues/{}/integrations/{}/?action=link'.format(
+            self.group.id, integration.id)
 
         with self.feature('organizations:integrations-issue-basic'):
             response = self.client.get(path)
@@ -61,13 +79,12 @@ def test_simple_get_link(self):
     def test_simple_get_create(self):
         self.login_as(user=self.user)
         org = self.organization
-        group = self.create_group()
-        self.create_event(group=group)
         integration = Integration.objects.create(
             provider='example',
             name='Example',
         )
         integration.add_organization(org, self.user)
+        group = self.group
 
         path = u'/api/0/issues/{}/integrations/{}/?action=create'.format(group.id, integration.id)
 
@@ -99,7 +116,7 @@ def test_simple_get_create(self):
                         'required': True,
                     }, {
                         'default': ('Sentry Issue: [%s](%s)\n\n```\n'
-                                    'Stacktrace (most recent call last):\n\n  '
+                                    'Stacktrace (most recent call first):\n\n  '
                                     'File "sentry/models/foo.py", line 29, in build_msg\n    '
                                     'string_max_length=self.string_max_length)\n\nmessage\n```'
                                     ) % (group.qualified_short_id, absolute_uri(group.get_absolute_url(params={'referrer': 'example_integration'}))),
@@ -121,15 +138,14 @@ def test_simple_get_create(self):
     def test_get_create_with_error(self):
         self.login_as(user=self.user)
         org = self.organization
-        group = self.create_group()
-        self.create_event(group=group)
         integration = Integration.objects.create(
             provider='example',
             name='Example',
         )
         integration.add_organization(org, self.user)
 
-        path = u'/api/0/issues/{}/integrations/{}/?action=create'.format(group.id, integration.id)
+        path = u'/api/0/issues/{}/integrations/{}/?action=create'.format(
+            self.group.id, integration.id)
 
         with self.feature('organizations:integrations-issue-basic'):
             with mock.patch.object(ExampleIntegration, 'get_create_issue_config', side_effect=IntegrationError('oops')):
@@ -141,15 +157,14 @@ def test_get_create_with_error(self):
     def test_get_feature_disabled(self):
         self.login_as(user=self.user)
         org = self.organization
-        group = self.create_group()
-        self.create_event(group=group)
         integration = Integration.objects.create(
             provider='example',
             name='Example',
         )
         integration.add_organization(org, self.user)
 
-        path = u'/api/0/issues/{}/integrations/{}/?action=create'.format(group.id, integration.id)
+        path = u'/api/0/issues/{}/integrations/{}/?action=create'.format(
+            self.group.id, integration.id)
 
         with self.feature({'organizations:integrations-issue-basic': False}):
             response = self.client.get(path)
@@ -167,7 +182,6 @@ def test_simple_put(self):
         integration.add_organization(org, self.user)
 
         path = u'/api/0/issues/{}/integrations/{}/'.format(group.id, integration.id)
-
         with self.feature('organizations:integrations-issue-basic'):
             response = self.client.put(path, data={
                 'externalIssue': 'APP-123'
@@ -367,8 +381,14 @@ def assert_default_project(path, action, expected_project_field):
 
         self.login_as(user=self.user)
         org = self.organization
-        group = self.create_group()
-        self.create_event(group=group)
+        event = self.store_event(
+            data={
+                'event_id': 'a' * 32,
+                'timestamp': self.min_ago.isoformat()[:19],
+            },
+            project_id=self.project.id
+        )
+        group = event.group
         integration = Integration.objects.create(
             provider='example',
             name='Example',

tests/sentry/api/endpoints/test_shared_group_details.py

@@ -1,6 +1,8 @@
 from __future__ import absolute_import, print_function
 
 import six
+from datetime import timedelta
+from django.utils import timezone
 
 from sentry.testutils import APITestCase
 from sentry.models import GroupShare
@@ -10,8 +12,14 @@ class SharedGroupDetailsTest(APITestCase):
     def test_simple(self):
         self.login_as(user=self.user)
 
-        group = self.create_group()
-        event = self.create_event(group=group)
+        min_ago = (timezone.now() - timedelta(minutes=1)).isoformat()[:19]
+        event = self.store_event(
+            data={
+                'timestamp': min_ago,
+            },
+            project_id=self.project.id,
+        )
+        group = event.group
 
         share_id = group.get_share_id()
         assert share_id is None
@@ -29,7 +37,7 @@ def test_simple(self):
 
         assert response.status_code == 200, response.content
         assert response.data['id'] == six.text_type(group.id)
-        assert response.data['latestEvent']['id'] == six.text_type(event.id)
+        assert response.data['latestEvent']['id'] == six.text_type(event.event_id)
         assert response.data['project']['slug'] == group.project.slug
         assert response.data['project']['organization']['slug'] == group.organization.slug
 

tests/sentry/integrations/bitbucket/test_issues.py

@@ -1,8 +1,14 @@
 from __future__ import absolute_import
 
+from datetime import timedelta
+import copy
+
+from django.utils import timezone
+
 from sentry.integrations.bitbucket.issues import ISSUE_TYPES, PRIORITIES
 from sentry.models import ExternalIssue, Integration
 from sentry.testutils import APITestCase
+from sentry.testutils.factories import DEFAULT_EVENT_DATA
 
 import json
 import responses
@@ -24,8 +30,18 @@ def setUp(self):
                 'subject': self.subject,
             }
         )
-        self.group = self.create_group()
-        self.create_event(group=self.group)
+        min_ago = (timezone.now() - timedelta(minutes=1)).isoformat()[:19]
+        event = self.store_event(
+            data={
+                'event_id': 'a' * 32,
+                'message': 'message',
+                'timestamp': min_ago,
+                'stacktrace': copy.deepcopy(DEFAULT_EVENT_DATA['stacktrace']),
+
+            },
+            project_id=self.project.id,
+        )
+        self.group = event.group
         self.repo_choices = [('myaccount/repo1', 'myaccount/repo1'),
                              ('myaccount/repo2', 'myaccount/repo2')]
         self.org_integration = self.integration.add_organization(self.organization)
@@ -203,7 +219,7 @@ def test_get_create_issue_config(self):
             }, {
                 'name': 'description',
                 'label': 'Description',
-                'default': u'Sentry Issue: [BAR-1](http://testserver/organizations/baz/issues/%d/?referrer=bitbucket_integration)\n\n```\nStacktrace (most recent call last):\n\n  File "sentry/models/foo.py", line 29, in build_msg\n    string_max_length=self.string_max_length)\n\nmessage\n```' % self.group.id,
+                'default': u'Sentry Issue: [BAR-1](http://testserver/organizations/baz/issues/%d/?referrer=bitbucket_integration)\n\n```\nStacktrace (most recent call first):\n\n  File "sentry/models/foo.py", line 29, in build_msg\n    string_max_length=self.string_max_length)\n\nmessage\n```' % self.group.id,
                 'type': 'textarea',
                 'autosize': True,
                 'maxRows': 10,

tests/sentry/integrations/github/test_issues.py

@@ -2,10 +2,12 @@
 
 import responses
 import six
+from datetime import timedelta
 
 from mock import patch
 from exam import fixture
 from django.test import RequestFactory
+from django.utils import timezone
 
 from sentry.integrations.github.integration import GitHubIntegration
 from sentry.models import Integration, ExternalIssue
@@ -28,6 +30,7 @@ def setUp(self):
         )
         self.model.add_organization(self.organization, self.user)
         self.integration = GitHubIntegration(self.model, self.organization.id)
+        self.min_ago = (timezone.now() - timedelta(minutes=1)).isoformat()[:19]
 
     @responses.activate
     @patch('sentry.integrations.github.client.get_jwt', return_value='jwt_token_1')
@@ -155,8 +158,13 @@ def test_link_issue(self, mock_get_jwt):
     @responses.activate
     @patch('sentry.integrations.github.client.get_jwt', return_value='jwt_token_1')
     def test_repo_dropdown_choices(self, mock_get_jwt):
-        group = self.create_group()
-        self.create_event(group)
+        event = self.store_event(
+            data={
+                'event_id': 'a' * 32,
+                'timestamp': self.min_ago,
+            },
+            project_id=self.project.id,
+        )
 
         responses.add(
             responses.POST,
@@ -176,7 +184,7 @@ def test_repo_dropdown_choices(self, mock_get_jwt):
             json={'repositories': [{'full_name': 'getsentry/sentry', 'name': 'sentry'}]}
         )
 
-        resp = self.integration.get_create_issue_config(group=self.group)
+        resp = self.integration.get_create_issue_config(group=event.group)
         assert resp[0]['choices'] == [(u'getsentry/sentry', u'sentry')]
 
         responses.add(
@@ -187,12 +195,12 @@ def test_repo_dropdown_choices(self, mock_get_jwt):
 
         # create an issue
         data = {'params': {'repo': 'getsentry/hello'}}
-        resp = self.integration.get_create_issue_config(group=self.group, **data)
+        resp = self.integration.get_create_issue_config(group=event.group, **data)
         assert resp[0]['choices'] == [(u'getsentry/hello', u'hello'),
                                       (u'getsentry/sentry', u'sentry')]
         # link an issue
         data = {'params': {'repo': 'getsentry/hello'}}
-        resp = self.integration.get_link_issue_config(group=self.group, **data)
+        resp = self.integration.get_link_issue_config(group=event.group, **data)
         assert resp[0]['choices'] == [(u'getsentry/hello', u'hello'),
                                       (u'getsentry/sentry', u'sentry')]
 
@@ -240,8 +248,15 @@ def test_default_repo_link_fields(self, mock_get_jwt):
                 ]
             },
         )
-        group = self.create_group()
-        self.create_event(group=group)
+        event = self.store_event(
+            data={
+                'event_id': 'a' * 32,
+                'timestamp': self.min_ago,
+            },
+            project_id=self.project.id,
+        )
+        group = event.group
+
         org_integration = self.integration.org_integration
         org_integration.config = {
             'project_issue_defaults': {
@@ -278,8 +293,14 @@ def test_default_repo_create_fields(self, mock_get_jwt):
             'https://api.github.com/installations/github_external_id/access_tokens',
             json={'token': 'token_1', 'expires_at': '2018-10-11T22:14:10Z'}
         )
-        group = self.create_group()
-        self.create_event(group=group)
+        event = self.store_event(
+            data={
+                'event_id': 'a' * 32,
+                'timestamp': self.min_ago,
+            },
+            project_id=self.project.id,
+        )
+        group = event.group
         org_integration = self.integration.org_integration
         org_integration.config = {
             'project_issue_defaults': {
@@ -304,10 +325,14 @@ def test_default_repo_link_fields_no_repos(self, mock_get_jwt):
                 'repositories': []
             },
         )
-        group = self.create_group()
-        self.create_event(group=group)
-
-        fields = self.integration.get_link_issue_config(group)
+        event = self.store_event(
+            data={
+                'event_id': 'a' * 32,
+                'timestamp': self.min_ago,
+            },
+            project_id=self.project.id,
+        )
+        fields = self.integration.get_link_issue_config(event.group)
         repo_field = [field for field in fields if field['name'] == 'repo'][0]
         assert repo_field['default'] is ''
         assert repo_field['choices'] == []
@@ -327,11 +352,14 @@ def test_default_repo_create_fields_no_repos(self, mock_get_jwt):
             'https://api.github.com/installations/github_external_id/access_tokens',
             json={'token': 'token_1', 'expires_at': '2018-10-11T22:14:10Z'}
         )
-
-        group = self.create_group()
-        self.create_event(group=group)
-
-        fields = self.integration.get_create_issue_config(group)
+        event = self.store_event(
+            data={
+                'event_id': 'a' * 32,
+                'timestamp': self.min_ago,
+            },
+            project_id=self.project.id,
+        )
+        fields = self.integration.get_create_issue_config(event.group)
         repo_field = [field for field in fields if field['name'] == 'repo'][0]
         assignee_field = [field for field in fields if field['name'] == 'assignee'][0]