ref(onobarding): Remove old onboarding experience

src/sentry/static/sentry/app/components/createProject.jsx

@@ -9,7 +9,6 @@ import {openCreateTeamModal} from 'app/actionCreators/modal';
 import {t} from 'app/locale';
 import Alert from 'app/components/alert';
 import Button from 'app/components/button';
-import HookStore from 'app/stores/hookStore';
 import PageHeading from 'app/components/pageHeading';
 import PlatformIconTile from 'app/components/platformIconTile';
 import PlatformPicker from 'app/components/platformPicker';
@@ -28,12 +27,6 @@ class CreateProject extends React.Component {
     api: PropTypes.object,
     teams: PropTypes.arrayOf(SentryTypes.Team),
     organization: SentryTypes.Organization,
-    nextStepUrl: PropTypes.func,
-  };
-
-  static defaultProps = {
-    nextStepUrl: ({slug, projectSlug, platform}) =>
-      `/onboarding/${slug}/${projectSlug}/configure/${platform}`,
   };
 
   static contextTypes = {
@@ -61,7 +54,7 @@ class CreateProject extends React.Component {
 
   createProject = e => {
     e.preventDefault();
-    const {organization, api, nextStepUrl} = this.props;
+    const {organization, api} = this.props;
     const {projectName, platform, team} = this.state;
     const {slug} = organization;
 
@@ -71,7 +64,7 @@ class CreateProject extends React.Component {
       Sentry.withScope(scope => {
         scope.setExtra('props', this.props);
         scope.setExtra('state', this.state);
-        Sentry.captureMessage('Onboarding no project name');
+        Sentry.captureMessage('No project name');
       });
     }
 
@@ -84,19 +77,12 @@ class CreateProject extends React.Component {
       success: data => {
         ProjectActions.createSuccess(data);
 
-        const urlData = {
-          slug: organization.slug,
-          projectSlug: data.slug,
-          platform: platform || 'other',
-        };
-
-        const defaultNextUrl = nextStepUrl(urlData);
-        const hookNextUrl =
-          organization.projects.length === 0 &&
-          HookStore.get('utils:onboarding-survey-url').length &&
-          HookStore.get('utils:onboarding-survey-url')[0](urlData, organization);
+        const platformKey = platform || 'other';
+        const nextUrl = `/${organization.slug}/${
+          data.slug
+        }/getting-started/${platformKey}/`;
 
-        browserHistory.push(hookNextUrl || defaultNextUrl);
+        browserHistory.push(nextUrl);
       },
       error: err => {
         this.setState({
@@ -112,7 +98,7 @@ class CreateProject extends React.Component {
             scope.setExtra('err', err);
             scope.setExtra('props', this.props);
             scope.setExtra('state', this.state);
-            Sentry.captureMessage('Onboarding project creation failed');
+            Sentry.captureMessage('Project creation failed');
           });
         }
       },

src/sentry/static/sentry/app/routes.jsx

@@ -45,12 +45,6 @@ const OrganizationMembersView = HookOrDefault({
     import(/* webpackChunkName: "OrganizationMembers" */ 'app/views/settings/organizationMembers'),
 });
 
-const OnboardingNewProjectView = HookOrDefault({
-  hookName: 'component:onboarding-new-project',
-  defaultComponentPromise: () =>
-    import(/* webpackChunkName: "OnboardingNewProject" */ 'app/views/onboarding/newProject'),
-});
-
 function routes() {
   const accountSettingsRoutes = (
     <React.Fragment>
@@ -786,33 +780,14 @@ function routes() {
       />
 
       <Route path="/onboarding/:orgId/" component={errorHandler(OrganizationContext)}>
-        {/* The current (old) version of the onboarding experience does not
-            route to anything here. So even though this is new, the route can
-            live where it will eventually live. */}
+        <IndexRedirect to="welcome/" />
         <Route
           path=":step/"
           componentPromise={() =>
             import(/* webpackChunkName: "OnboardingWizardNew" */ 'app/views/onboarding/wizardNew')
           }
           component={errorHandler(LazyLoad)}
         />
-        {/* TODO(epurkhiser): Old style onboarding experience routes. To be removed in the future */}
-        <Route
-          componentPromise={() =>
-            import(/* webpackChunkName: "OnboardingWizard" */ 'app/views/onboarding/wizard')
-          }
-          component={errorHandler(LazyLoad)}
-        >
-          <IndexRoute component={errorHandler(OnboardingNewProjectView)} />
-          <Route
-            path=":projectId/configure/:platform/"
-            componentPromise={() =>
-              import(/* webpackChunkName: "OnboardingConfigure" */ 'app/views/onboarding/configure')
-            }
-            component={errorHandler(LazyLoad)}
-          />
-          {hook('routes:onboarding')}
-        </Route>
       </Route>
       <Route component={errorHandler(OrganizationDetails)}>
         <Route path="/settings/" name="Settings" component={SettingsWrapper}>

src/sentry/static/sentry/app/stores/hookStore.jsx

@@ -6,7 +6,6 @@ const validHookNames = new Set([
   // Additional routes
   'routes',
   'routes:admin',
-  'routes:onboarding',
   'routes:organization',
   'routes:organization-root',
 
@@ -40,11 +39,7 @@ const validHookNames = new Set([
   'sidebar:item-label',
 
   // Onboarding experience
-  // TODO(epurkhiser): These all should become less getsentry specific
-  'utils:onboarding-survey-url',
-  'sidebar:onboarding-assets',
   'onboarding:invite-members',
-  'component:onboarding-new-project',
 
   // Used to provide a component for integration features.
   'integrations:feature-gates',

src/sentry/static/sentry/app/views/onboarding/platform.jsx

@@ -46,7 +46,7 @@ class OnboardingPlatform extends React.Component {
     progressing: false,
   };
 
-  componentDidUpdate(prevProps, prevState) {
+  componentDidUpdate(prevProps) {
     if (prevProps.active && !this.props.active) {
       // eslint-disable-next-line react/no-did-update-set-state
       this.setState({progressing: false});
@@ -144,6 +144,7 @@ class OnboardingPlatform extends React.Component {
           setPlatform={this.handleSetPlatform}
         />
         <Button
+          data-test-id="platform-select-next"
           priority="primary"
           disabled={continueDisabled}
           onClick={this.handleContinue}