Skip to content

ref(onboarding): Fix install prompt URL #14106

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Jul 23, 2019
Merged

ref(onboarding): Fix install prompt URL #14106

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
15 changes: 6 additions & 9 deletions src/sentry/static/sentry/app/views/organizationDetails/installPromptBanner.jsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -32,21 +32,18 @@ class InstallPromptBanner extends React.Component {
return !!projects.find(p => p.firstEvent) || !!config.sentFirstEvent;
}

getUrl() {
get url() {
const {organization} = this.props;
// if no projects - redirect back to onboarding flow
let url = `/onboarding/${organization.slug}`;

// if project with a valid platform then go straight to instructions
const projects = organization.projects;
const projectCount = projects.length;
if (projectCount > 0 && getPlatformName(projects[projectCount - 1].platform)) {
const project = projects[projectCount - 1];
url = `/onboarding/${organization.slug}/${project.slug}/configure/${
project.platform
}`;
return `/onboarding/${organization.slug}/get-started/`;
}
return url;

// if no projects - redirect back to onboarding flow
return `/onboarding/${organization.slug}/`;
}

recordAnalytics() {
Expand Down Expand Up @@ -77,7 +74,7 @@ class InstallPromptBanner extends React.Component {
<React.Fragment>
{!hideBanner && (
<StyledAlert type="warning" icon="icon-circle-exclamation" system="system">
<a onClick={() => this.recordAnalytics()} href={this.getUrl()}>
<a onClick={() => this.recordAnalytics()} href={this.url}>
{t(
"You're almost there! Start capturing errors with just a few lines of code."
)}
Expand Down