test(ui): Mock the onboarding learn more video #14108
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
evanpurkhiser
commented
Jul 22, 2019
| import space from 'app/styles/space'; | ||
|
|
||
| const LEARN_MORE_VIDEO = 'https://player.vimeo.com/video/319554213'; | ||
|
|
||
| const learnMoveVideo = getDynamicText({ |
There was a problem hiding this comment.
Not great that this function is called getDynamicText
billyvg
reviewed
Jul 23, 2019
| import space from 'app/styles/space'; | ||
|
|
||
| const LEARN_MORE_VIDEO = 'https://player.vimeo.com/video/319554213'; | ||
|
|
||
| const learnMoveVideo = getDynamicText({ | ||
| fixed: null, |
There was a problem hiding this comment.
I would put placeholder text here so that people looking at the snapshots know there's a placeholder (instead of it looking like the video is just missing)
There was a problem hiding this comment.
Will open a separate PR to do
billyvg
approved these changes
Jul 23, 2019
evanpurkhiser
deleted the
evanpurkhiser/testui-mock-the-onboarding-learn-more-video
branch
jan-auer
added a commit
that referenced
this pull request
Jul 24, 2019
* master: (115 commits) feat: Update to JS SDK 5.6.0-beta.1 + 0.10.2 sentry-python (#14116) fix(apm): Whitelist dev.getsentry.net for local development (#14117) test(datasets): Make Sentry use generic test functions in Snuba (#14111) ref(suspect-commits): Add text changes to empty state (#14121) build: Switch to psycopg2-binary feat(api): Add option to fetch Organization details without Pr… (#13925) ref: Remove EventDetails endpoint (#14107) test(ui): Mock the onboarding learn more video (#14108) tests(acceptance): Add tests for resolving issues in Issues Li… (#14069) feat(ui): Add basic templates for Incident Rules in settings (#14112) feat(eventsv2) Add basic transaction list (#14103) ref(environments) Optimize environment queries (#14102) fix(events-v2) Add additional user attributes to the user column (#14101) fix: Don't start pageload transaction (#14115) feat: APM Sentry Frontend (#14027) ref(onboarding): Fix install promprt URL (#14106) fix(app-platform): Allow GET requests for published apps (#14109) feat: Update Group.get_latest_event to use Snuba event (#14039) ref(onboarding): Rename wizardNew -> onboarding (#14104) feat(apm): Update props to address proptype warnings for new transaction attributes (SEN-800) (#14040) ...
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes flakey percy tests